-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add About Page #127
feat: Add About Page #127
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for sprightly-parfait-386400 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Ramón, this is great work, thank you!
I've left some comments.
@@ -12,6 +12,7 @@ type Props = { | |||
|
|||
export const CalloutConfig: ComponentConfig<Props> = { | |||
fields: { | |||
//@ts-ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We really shouldn't be using ts-ignore
. Let's find a way to do this with proper type checking, please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah you're right thank you, I'll make those changes.
Closes #99
I also noticed a crash when running the website, so I added a @tsignore for it