Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add About Page #127

Closed
wants to merge 5 commits into from
Closed

Conversation

hola-soy-milk
Copy link

Closes #99

I also noticed a crash when running the website, so I added a @tsignore for it

Copy link

vercel bot commented Feb 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 9, 2024 7:04pm

Copy link

netlify bot commented Feb 9, 2024

Deploy Preview for sprightly-parfait-386400 ready!

Name Link
🔨 Latest commit 0fe331e
🔍 Latest deploy log https://app.netlify.com/sites/sprightly-parfait-386400/deploys/65c676e17c856c000854f8f3
😎 Deploy Preview https://deploy-preview-127--sprightly-parfait-386400.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Author

@hola-soy-milk hola-soy-milk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Ramón, this is great work, thank you!

I've left some comments.

@@ -12,6 +12,7 @@ type Props = {

export const CalloutConfig: ComponentConfig<Props> = {
fields: {
//@ts-ignore
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really shouldn't be using ts-ignore. Let's find a way to do this with proper type checking, please?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah you're right thank you, I'll make those changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create "About" page
1 participant