Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configuration: store verification key in configuration file #7

Closed
achille-roussel opened this issue Apr 12, 2024 · 1 comment
Closed
Labels
enhancement New feature or request

Comments

@achille-roussel
Copy link
Contributor

When rolling out a new verification key, we print the new key to the console but the user is responsible for adding it to its code or environment.

We could simplify this process by storing the public key in the configuration file. The dispatch run command could then read it from the file and automatically set it as an environment variable.

Relates to #6

@achille-roussel achille-roussel added the enhancement New feature or request label Apr 12, 2024
@chriso
Copy link
Contributor

chriso commented Apr 16, 2024

Using a verification key in dispatch run serves no purpose, since the CLI pulls requests from an authenticated API endpoint.

We could fetch or generate a verification key in the CLI, and set DISPATCH_VERIFICATION_KEY in dispatch run, however this only adds footguns for the user. If they roll-out a new verification key through the UI, or using the CLI on a different machine, the cached verification key in the config will no longer work.

Instead of caching a verification key, and using it in dispatch run, I'll instead hide the warning about a lack of verification key in the SDK: dispatchrun/dispatch-py#152.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants