From 4b20f7fbb448bb143b5a10b79544f413a4ac7b4c Mon Sep 17 00:00:00 2001 From: Achille Roussel Date: Mon, 22 Apr 2024 18:37:09 -0700 Subject: [PATCH] PR feedback Signed-off-by: Achille Roussel --- README.md | 11 ++++++++--- src/dispatch/http.py | 1 - 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index 8160e27..e24570a 100644 --- a/README.md +++ b/README.md @@ -21,10 +21,11 @@ Python package to develop applications with the Dispatch platform. - [Installing the Dispatch CLI](#installing-the-dispatch-cli) - [Installing the Dispatch SDK](#installing-the-dispatch-sdk) - [Usage](#usage) - - [Configuration](#configuration) + - [Writing Dispatch Applications](#writing-dispatch-applications) - [Running Dispatch Applications](#running-dispatch-applications) - - [Distributed Coroutines for Python](#distributed-coroutines-for-python) + - [Writing Transactional Applications with Dispatch](#writing-transactional-applications-with-dispatch) - [Integration with FastAPI](#integration-with-fastapi) + - [Configuration](#configuration) - [Serialization](#serialization) - [Examples](#examples) - [Contributing](#contributing) @@ -98,7 +99,7 @@ dispatch login Then we are ready to run the example program we wrote above: ```console -dispatch run -- main.py +dispatch run -- python3 main.py ``` ### Writing Transactional Applications with Dispatch @@ -193,6 +194,10 @@ program, driven by the Dispatch SDK. ### Configuration +The Dispatch CLI automatically configures the SDK, so manual configuration is +usually not required when running Dispatch applications. However, in some +advanced cases, it might be useful to explicitly set configuration options. + In order for Dispatch to interact with functions remotely, the SDK needs to be configured with the address at which the server can be reached. The Dispatch API Key must also be set, and optionally, a public signing key should be diff --git a/src/dispatch/http.py b/src/dispatch/http.py index 0635fc3..1d5b1bd 100644 --- a/src/dispatch/http.py +++ b/src/dispatch/http.py @@ -194,4 +194,3 @@ def do_POST(self): self.send_header("Content-Type", "application/proto") self.end_headers() self.wfile.write(response.SerializeToString()) - return