Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to AHC 3.0.0 #239

Closed
maiflai opened this issue Aug 3, 2024 · 5 comments
Closed

Upgrade to AHC 3.0.0 #239

maiflai opened this issue Aug 3, 2024 · 5 comments

Comments

@maiflai
Copy link
Contributor

maiflai commented Aug 3, 2024

Problem statement
AHC 3.0.0 has been released and contains breaking changes i.e. dispatch users cannot upgrade transitively.

  • Timeouts are now passed as java.time.Duration
  • oauth1 is no longer supported

Proposed solution
Upgrade Dispatch to support AHC 3.0.0 without retaining backwards compatibility.

Has anyone begun looking at this please?

@farmdawgnation
Copy link
Member

I haven't been looking at this yet. I've done some experimentation, actually, with removing AHC from the build chain entirely in favor of Java's native http client, but ran into some other issues there so far. Ultimately it's been a bit since I've had time to work on this, but if AHC 3 is out I can take a look at updating the library.

@maiflai
Copy link
Contributor Author

maiflai commented Aug 3, 2024

ah great, thanks very much. It looks relatively straightforward - does #240 seem reasonable?

@farmdawgnation
Copy link
Member

Yes, looks reasonable. I've left you a comment on there. I'm going to start thinking about how I want to package this up for release.

@farmdawgnation
Copy link
Member

This has been incorporated into the 2.0.0 release, which is now live on maven central.

@maiflai
Copy link
Contributor Author

maiflai commented Aug 27, 2024

great, thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants