Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add target package as dev in active environment #54

Merged
merged 2 commits into from
May 31, 2024

Conversation

disberd
Copy link
Owner

@disberd disberd commented May 31, 2024

This PR will add the target package as dev dependency in the active environment handled by PlutoDevMacros.
This is not done by directly calling Pkg.develop as this will always recompile the environment.
Instead, after copying the target project and manifest in the active environment, the target package is added as dev dependency to the Project and Manifest objects (in the project and manifest field of the active EnvCache).

As part of this PR, some internal functions have also been changed to update methodology.

This change should simplify locating the target package with Base.locate_package_env automatically, which will help with migrating to loading extensions with the standard approach using Base methods

Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (793507b) to head (2b933b7).

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #54   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines          813       820    +7     
=========================================
+ Hits           813       820    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@disberd disberd merged commit 1be5847 into master May 31, 2024
9 checks passed
@disberd disberd deleted the dev_target_to_active branch May 31, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant