-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python 3.8.5 compatibility #32
Comments
Yes, and no plans to migrate to python 3 at the moment. |
but we must take into aacount if this script is going to be used in a **PCI environment it should be supported with a supported version of Python, version 2.7 is EOL according to[https://www.python.org/dev/peps/pep-0373/]. |
You can use a binary that I have provided, so you don't need to install Python on the target. |
|
Hi, |
I've created a pull request for this. #33 it's not a major change but i hope it helps others |
Thank you @dawesc ! I will review. |
Sorry, some errors testing those changes, so can't merge at present. |
Has this been fixed or is it working in Python 3? |
Is there any way we can get involved in this and help you fix the errors? |
I would be happy to try and correct the issues, could you provide some details on how to reproduce them? |
@dawesc I think I have found (and corrected) some of the errors, would you prefer that I send you a pull request, or that I open a new pull request based on your fork? (There were some issues with things nested in zipfiles, and there are some fairly nasty file descriptor leaks for some failures like 'file is not a valid CFB'. I'm not convinced that the latter is new with your changes, however it definitely crashed panhunt in my test environment.) |
is PAN hunt script conceived to work only with python 2.7?
The text was updated successfully, but these errors were encountered: