Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python 3.8.5 compatibility #32

Open
rickespana opened this issue Aug 17, 2020 · 12 comments
Open

python 3.8.5 compatibility #32

rickespana opened this issue Aug 17, 2020 · 12 comments

Comments

@rickespana
Copy link

is PAN hunt script conceived to work only with python 2.7?

@bli-dn
Copy link
Contributor

bli-dn commented Aug 17, 2020

Yes, and no plans to migrate to python 3 at the moment.

@rickespana
Copy link
Author

but we must take into aacount if this script is going to be used in a **PCI environment it should be supported with a supported version of Python, version 2.7 is EOL according to[https://www.python.org/dev/peps/pep-0373/].

@bli-dn
Copy link
Contributor

bli-dn commented Aug 18, 2020

You can use a binary that I have provided, so you don't need to install Python on the target.

@rickespana
Copy link
Author

You can use a binary that I have provided, so you don't need to install Python on the target. Got it, but there are some environments that is not possible to execute a program brought from outside the CDE it is more probable they let a properly audited python script from a recognized source. Thanks for the reply @bli-dn we will try to port the script to python-3 to see if it work.

@shrutikaponde
Copy link

Hi,
Any update on this?
@rickespana, have you worked further to add python 3.8 compatibilities?

@dawesc
Copy link

dawesc commented Feb 1, 2021

I've created a pull request for this. #33 it's not a major change but i hope it helps others

@bli-dn
Copy link
Contributor

bli-dn commented Feb 1, 2021

Thank you @dawesc ! I will review.

@bli-dn
Copy link
Contributor

bli-dn commented Feb 1, 2021

Sorry, some errors testing those changes, so can't merge at present.

@korang
Copy link

korang commented Feb 13, 2021

I've created a pull request for this. #33 it's not a major change but i hope it helps others

Has this been fixed or is it working in Python 3?

@AlexanderMer
Copy link

Is there any way we can get involved in this and help you fix the errors?
You can include tests in the source code and contributors will run them before submitting a PR and it will save you some time.

@zelch
Copy link

zelch commented Sep 7, 2021

Sorry, some errors testing those changes, so can't merge at present.

I would be happy to try and correct the issues, could you provide some details on how to reproduce them?

@zelch
Copy link

zelch commented Sep 7, 2021

@dawesc I think I have found (and corrected) some of the errors, would you prefer that I send you a pull request, or that I open a new pull request based on your fork?

(There were some issues with things nested in zipfiles, and there are some fairly nasty file descriptor leaks for some failures like 'file is not a valid CFB'. I'm not convinced that the latter is new with your changes, however it definitely crashed panhunt in my test environment.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants