Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entity removals are sometimes missed when using a fixed schedule #599

Closed
DiSaber opened this issue Dec 3, 2024 · 1 comment · Fixed by #600
Closed

Entity removals are sometimes missed when using a fixed schedule #599

DiSaber opened this issue Dec 3, 2024 · 1 comment · Fixed by #600

Comments

@DiSaber
Copy link
Contributor

DiSaber commented Dec 3, 2024

I've just started experiencing an issue where removed entities are still collidable and raycasts are still detecting them. My rapier plugin setup: RapierPhysicsPlugin::<NoUserData>::default().with_length_unit(1.0).in_schedule(FixedPostUpdate).
Attached is a video where I show the ramp in the main area and then enter a map (which removes all the main area's entities). As shown, the ramp is still collidable even though the entity has been removed. I just updated to the bevy 0.15 branch from the pr but I doubt that's the issue. It looks like this commit (src/plugin/plugin.rs line 219) removed the systems::sync_removals system from PostUpdate but as the comment states: "These must be in the main schedule currently so that they do not miss events." I think that line is likely the culprit and the simplest solution is to just add it back.

Youtube link (github won't let me upload video since it's >10mb): https://youtu.be/iyIRC7qQOSk

Workaround: Use with_default_system_setup(false) and configure the system sets manually, with systems::sync_removals in PostUpdate as before.

@Vrixyz
Copy link
Contributor

Vrixyz commented Dec 4, 2024

Thanks for the report! Let me know if you're still having issues with #600 fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants