Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider showing warning about allowed domains for email delivery when in dev & stage environments #67

Open
timiwahalahti opened this issue Mar 30, 2023 · 1 comment

Comments

@timiwahalahti
Copy link
Contributor

Currently, you need to know that we limit the domains to which emails can be sent when in development and staging environments. When the receiving address is not in that domain, the to-address is forced to be ours.

We probably should show visible reminder about this on the dashboard since this doesn't affect us but can cause issues for developers that aren't from our company. The notice could be dismissible.

Why notice instead, for example, defaulting the forced address to admin_email? Because when working on a site that has been in production already, that email can be clients instead of ours.

I've also thought about detecting if we're on Dude dev or stage env, to put the email forcing on only in those situations. But haven't yet come up with a solution that would be reliable.

Thoughts @ronilaukkarinen @EliasKau?

@ronilaukkarinen
Copy link
Member

We discussed options verbally, but let me note here. Options:

  • Notification
  • Somehow getting the information that it's our repo, either some kind of private repository list or getting the info from .git/config - or something

I'm all for notification if nothing else works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants