-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[droplets]: add support for droplet backup policy #1609
Conversation
… use a separate droplet action for that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Left a few comments in-line from my first pass review. Would be great to get some integration-style tests as well.
Thinking about the overall structure, it might make sense to group these new commands together under a backup-policies
sub command. Something like:
doctl compute droplet backup-policies get
doctl compute droplet backup-policies list
doctl compute droplet backup-policies list-supported
It feels a bit cleaner to me. What do you think?
…nabling; revert changes in integration tests
…nd backup policy applied
…egration tests for droplet backup policies get
…policies for all droplets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌 LGTM!
This PR adds droplet backup policy to doctl.
For droplets on:
For droplet actions on:
--backup-policy
)Thanks 🦈