-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve SingleFile import #47
Comments
I agree that I should improve my procedure. The things that I don't like is the fact that the |
Hey, thanks so much for looking into this. Would it be possible to... load these files from the internet, kind of like what unpkg.com do? |
I wouldn't recommend to retrieve the files from unpkg.com because browser vendors want to ensure extensions don't contain remotely hosted code, see https://developer.chrome.com/docs/extensions/mv3/intro/mv3-overview/#remotely-hosted-code and https://bugzilla.mozilla.org/show_bug.cgi?id=1594234. |
Right now we're following procedure recommended by SingleFile to accomplish this.
The result, however, is a considerable skew given that the SingleFile code, which we understand and intend to use as a module, is included in the repo as if it were ours.
Maybe this is a question best asked to @gildas-lormeau, actually 👋
Is there a better way, which is more akin to a module for us and avoids us shipping your code?
Thank you so much for your help
The text was updated successfully, but these errors were encountered: