Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve SingleFile import #47

Open
basilesimon opened this issue Aug 18, 2021 · 3 comments
Open

Improve SingleFile import #47

basilesimon opened this issue Aug 18, 2021 · 3 comments

Comments

@basilesimon
Copy link
Member

Right now we're following procedure recommended by SingleFile to accomplish this.

The result, however, is a considerable skew given that the SingleFile code, which we understand and intend to use as a module, is included in the repo as if it were ours.

Maybe this is a question best asked to @gildas-lormeau, actually 👋

Is there a better way, which is more akin to a module for us and avoids us shipping your code?

Thank you so much for your help

@gildas-lormeau
Copy link

gildas-lormeau commented Aug 18, 2021

I agree that I should improve my procedure. The things that I don't like is the fact that the dist folder is hard-coded and there should be only 5 built files (2 content scripts, 1 background script and 2 web accessible resources). I don't think there is an easy way to provide this code as a module or something similar though because of the manifest.json file which must include the paths to these files.

@basilesimon
Copy link
Member Author

Hey, thanks so much for looking into this.

Would it be possible to... load these files from the internet, kind of like what unpkg.com do?

@gildas-lormeau
Copy link

I wouldn't recommend to retrieve the files from unpkg.com because browser vendors want to ensure extensions don't contain remotely hosted code, see https://developer.chrome.com/docs/extensions/mv3/intro/mv3-overview/#remotely-hosted-code and https://bugzilla.mozilla.org/show_bug.cgi?id=1594234.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants