Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorproate did-jwk patch upstream. #3

Open
davidlehn opened this issue Jan 18, 2024 · 2 comments
Open

Incorproate did-jwk patch upstream. #3

davidlehn opened this issue Jan 18, 2024 · 2 comments
Assignees
@kezike

Comments

@davidlehn
Copy link
Member

The patching system used here seems fragile. Please work with @or13/did-jwk upstream to incorporate and release the patch, make any adjustments as needed if/when that happens, and remove the patching infrastructure from this project.
@davidlehn
Copy link
Member Author

Apparently patching is not supported in dependencies, so an alternate solution is needed to fix 1.0.0:
ds300/patch-package#270
ds300/patch-package#84 (comment)

@davidlehn
Copy link
Member Author

The patch was removed in #4 due to it not currently being needed. The contexts were fixed up locally. The context change should go upstream. And perhaps the publicKeyJwk feature as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kezike kezike

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davidlehn @kezike