Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OakCLI will crash with accounts having more than 32 devices #22

Open
pfeerick opened this issue Dec 16, 2016 · 0 comments
Open

OakCLI will crash with accounts having more than 32 devices #22

pfeerick opened this issue Dec 16, 2016 · 0 comments

Comments

@pfeerick
Copy link

pfeerick commented Dec 16, 2016

Due to usage of readlineSync.keyInSelect() to display the device list and get input, Particle accounts having more than 32 devices will cause OakCLI to crash, as readlineSync.keyInSelect() has a limit of 35 entries. Some processing needs to be added to split the device list into more management chunks, which should then mitigate the issue.

The compiled exe will throw the following message

nexe.js:43674
    { throw '`items` must be Array (max length: 35).'; }
      ^
`items` must be Array (max length: 35).

Whereas the source run through node will throw the following (similar) message:

C:\Users\Peter\Desktop\OakCLI\node_modules\readline-sync\lib\readline-sync.js:1263
    throw '`items` must be Array (max length: 35).';
    ^
`items` must be Array (max length: 35).

http://digistump.com/board/index.php/topic,2489.msg11969.html#msg11969

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant