Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to .net core 3.1 #32

Open
XeNz opened this issue Dec 18, 2019 · 1 comment
Open

Upgrade to .net core 3.1 #32

XeNz opened this issue Dec 18, 2019 · 1 comment

Comments

@XeNz
Copy link

XeNz commented Dec 18, 2019

Currently this library is incompatible with .NET Core 3.0 and upwards.

I would like to suggest an upgrade to support .NET Core 3.1 projects.
This would entail:

  • Upgrading any Microsoft.AspNetCore package to 3.1.0 if possible
  • Adding the new Newtonsoft package
  • Resolving MvcOptions issues
  • Rewriting IUrlHelper DI, this has also changed since 3.0
  • Upgrading the Swashbuckle library to 5.0.0-rc5. This holds many breaking changes and will also result into Swagger OperationFilters and DocumentFilters to be rewritten.
  • Updating the sample project to accomodate these changes

Why?

.NET Core 2.2 will reach End of Life on December 23, 2019. This means it's a good idea for projects to get upgraded to 3.0 and onwards.

Created a PR as starting point:

#33

Currently broken:

  • Versioning
  • Usage of MvcOptions, as expected.

Questionmarks:

  • ValidRefUri filter
  • Need a workaround for setting Consumes and Produces
@XeNz
Copy link
Author

XeNz commented Dec 19, 2019

Update on PR:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant