Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shrink image another 20MB with separate node_modules ci --omit=dev stage #244

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

rmlearney-digicatapult
Copy link
Contributor

@rmlearney-digicatapult rmlearney-digicatapult commented Nov 16, 2024

Pull Request

Checklist

  • Have you read Digital Catapult's Code of Conduct?
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

PR Type

Please delete options that are irrelevant.

  • Chore

Linked tickets

High level description

Reduce docker image further 20MB to 264MB

Detailed description

Using separate layer to install node_modules with ci --omit=dev and copying into final production image prevents unnecessary transfer of cache

Describe alternatives you've considered

Operational impact

Additional context

@rmlearney-digicatapult rmlearney-digicatapult requested a review from a team as a code owner November 16, 2024 14:11
@rmlearney-digicatapult rmlearney-digicatapult marked this pull request as draft November 16, 2024 14:18
@rmlearney-digicatapult rmlearney-digicatapult marked this pull request as ready for review November 16, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant