Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/vr 263 #238

Merged
merged 10 commits into from
Nov 18, 2024
Merged

Feature/vr 263 #238

merged 10 commits into from
Nov 18, 2024

Conversation

n3op2
Copy link
Contributor

@n3op2 n3op2 commented Nov 14, 2024 •
edited
Loading

Pull Request

Checklist

  • Have you read Digital Catapult's Code of Conduct?
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

PR Type

Please delete options that are irrelevant.

  • Feature

Linked tickets

https://digicatapult.atlassian.net/browse/VR-263

High level description

New admin invite email template with the new copy

Detailed description

Changes:

  • unit test updates
  • admin email template update
  • screenshot comparison for homepage

Operational impact

Low/None

@n3op2 n3op2 marked this pull request as ready for review November 15, 2024 08:03
@n3op2 n3op2 requested a review from a team as a code owner November 15, 2024 08:03
@n3op2 n3op2 merged commit 1815442 into main Nov 18, 2024
10 checks passed
@n3op2 n3op2 deleted the feature/vr-263 branch November 18, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattdean-digicatapult mattdean-digicatapult mattdean-digicatapult approved these changes

@Ellenn-A Ellenn-A Awaiting requested review from Ellenn-A

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@n3op2 @mattdean-digicatapult