Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: VR-70
This PR adds the list connection controller and some stubs for the views. It includes the unit tests for the controller itself but currently no integration tests. Now on to the fun:
Firstly this is about as good as I think I can get it. There's a bug mochajs/mocha#5139 which means that test names aren't reported correctly because we're dynamically importing
chai
. To get round this I've got some really evil boiler plate that looks like:Now I have tried a tonne of stuff to make this better. I can't seem to set globals that
tsimp
will correctly find and I can't get chai to load synchronously. So this is as good as I can think until the above issue is resolved