Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/connection controller #10

Merged
merged 4 commits into from
May 8, 2024

Conversation

mattdean-digicatapult
Copy link
Contributor

@mattdean-digicatapult mattdean-digicatapult commented May 8, 2024

Ticket: VR-70

This PR adds the list connection controller and some stubs for the views. It includes the unit tests for the controller itself but currently no integration tests. Now on to the fun:

Firstly this is about as good as I think I can get it. There's a bug mochajs/mocha#5139 which means that test names aren't reported correctly because we're dynamically importing chai. To get round this I've got some really evil boiler plate that looks like:

let expect: Chai.ExpectStatic
before(async () => {
  expect = (await import('chai')).expect
})

Now I have tried a tonne of stuff to make this better. I can't seem to set globals that tsimp will correctly find and I can't get chai to load synchronously. So this is as good as I can think until the above issue is resolved

@mattdean-digicatapult mattdean-digicatapult force-pushed the chore/connection-controller branch from cbe2f26 to cedf7e0 Compare May 8, 2024 14:22
@mattdean-digicatapult mattdean-digicatapult marked this pull request as ready for review May 8, 2024 14:56
@mattdean-digicatapult mattdean-digicatapult requested a review from a team as a code owner May 8, 2024 14:56
src/views/connection.tsx Show resolved Hide resolved
@mattdean-digicatapult mattdean-digicatapult merged commit a53af57 into main May 8, 2024
8 checks passed
@mattdean-digicatapult mattdean-digicatapult deleted the chore/connection-controller branch May 8, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants