Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

be able to turn off popover auto placement #2658

Open
Barsnes opened this issue Oct 22, 2024 · 0 comments · May be fixed by #2659
Open

be able to turn off popover auto placement #2658

Barsnes opened this issue Oct 22, 2024 · 0 comments · May be fixed by #2659
Labels
react @digdir/designsystemet-react

Comments

@Barsnes
Copy link
Member

Barsnes commented Oct 22, 2024

Currently the popover tries to stay in the viewport, but still anchored to its reference element.
We should add a prop autoPlacement so consumers can turn this off.

image
The bottom popovers here has placement="bottom", but are moved up because the edge of the viewport would hide them.

I believe this should be default behaviour, but this can be discussed
@Barsnes Barsnes added the react @digdir/designsystemet-react label Oct 22, 2024
Barsnes added a commit that referenced this issue Oct 22, 2024
@Barsnes
feat(popover): add autoPlacement prop
398d99e 
Fixes #2658

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/digdir/designsystemet/issues/2658?shareId=XXXX-XXXX-XXXX-XXXX).
@Barsnes Barsnes linked a pull request Oct 22, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
react @digdir/designsystemet-react
Projects
Team Design System
Status: 👀 Ready for review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(popover): add autoPlacement prop digdir/designsystemet
1 participant
@Barsnes