Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure consistent component token name vs. CSS prop token usage #2638

Open
eirikbacker opened this issue Oct 18, 2024 · 0 comments
Open

Ensure consistent component token name vs. CSS prop token usage #2638

eirikbacker opened this issue Oct 18, 2024 · 0 comments
Assignees
@eirikbacker
Labels
css @digdir/designsystemet-css

Comments

@eirikbacker
Copy link
Contributor

eirikbacker commented Oct 18, 2024 •
edited
Loading

Sometimes we make component tokens like --dsc-button-background, but use it both for background: var(--dsc-button-background) and color: var(--dsc-button-background). This is problematic as color does not support alt the values background does, and thus gives our uses false promises of supported values in --dsc-button-background.
This applies to padding, gap etc, so we should just do a checkup on all components, and ensure some shared conventions in the outliers where CSS property based names does not make sense.
@eirikbacker eirikbacker self-assigned this Oct 18, 2024
@eirikbacker eirikbacker added the css @digdir/designsystemet-css label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eirikbacker eirikbacker

Labels
css @digdir/designsystemet-css
Projects
Team Design System
Status: 📄 Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eirikbacker