Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Additional <exclude> on a per-step basis #1607

Closed
blacelle opened this issue Mar 7, 2023 · 2 comments
Closed

[Feature Request] Additional <exclude> on a per-step basis #1607

blacelle opened this issue Mar 7, 2023 · 2 comments

Comments

@blacelle
Copy link
Contributor

blacelle commented Mar 7, 2023

In some cases, one need to exclude some step for some files. It happens in project requiring faulty code to remain faulty.

For instance :

This need is especially useful with new steps enabling linting (cleanthat, eclipse cleanup, etc), which is more opinionated than formatting.

  • I believe it would be bad that each step implement implement its own exclusion mechanism, which it could be one way to go (through FilterByFileFormatterStep).
  • Is there any existing mechanism to achieve this ?
  • Is this was introduced as a new-feature, what would be the recommended design?
@nedtwigg
Copy link
Member

nedtwigg commented Mar 7, 2023

There is no existing mechanism to achieve this. I would probably name it skipStep. Something like

skipStep('cleanthat').forFiles('Blah.java')

It is blocked on #1096. I try very hard not to be a blocker for things that people want to get merged, but there's a couple structural things that are piling up while I remain responsive on minor issues. I'm going to go dark on issues and PR's for the rest of this week until I am able to get a few of these blockers completed and merged.

@nedtwigg
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants