fix: jpeg exif orientation rendering #2529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9cd403d The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mskec
pushed a commit
to mskec/react-pdf
that referenced
this pull request
Feb 26, 2024
* fix: jpeg exif orientation rendering * refactor: remove test comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on: foliojs/pdfkit#1482 . Props to PR author
Fixes: #1848
Fixes: #1391
I want to eventually switch into using pdfkit main package. However, this has some big difference with how my fork ended up being and it's quite hard to unify. The approach I'll try is slowly converge files until codebase is equal, and only remaining thing is build scripts and dependencies version. From there I'll be able to see more clearly what are the differences