Deleting static block also deletes products

[emilian]

I had a big surprise today where deleting a static block also removed the products referencing the block. To stop this the lfs/catalog/models.py file should use on_delete=models.SET_NULL for the static_block foreign key. Like this:

static_block = models.ForeignKey("StaticBlock", on_delete=models.SET_NULL, verbose_name=_(u"Static block"), blank=True, null=True, related_name="products")

That should solve the problem for the products.

[emilian]

Looks good.

Is it possible to do the same for categories as well?

[emilian]

Right now the code is manually setting the static_block field to null for categories.

Here's the relevant code:

https://github.com/diefenbach/django-lfs/blob/master/lfs/manage/static_blocks/views.py#L247

That code could be removed with the same setting for the category model as well.

[pigletto]

I've updated the Pull Request. Seems that code for setting None was created before on_delete was added to Django.

[emilian]

That was fast. Thanks!