Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sessions to zipline #554

Closed
wants to merge 16 commits into from

Conversation

TacticalTechJay
Copy link
Collaborator

@TacticalTechJay TacticalTechJay commented May 10, 2024

This should resolve #552.

This PR adds sessions, here's how it'll work

  • a session's default lifetime will follow the cookie's expiration date of 2 weeks
  • a daily interval for clearing out dead sessions
  • changing the password to a user will invalidate current sessions for said user
  • listing a user's own sessions in their manage user page

Oh and I may have changed the devcontainer a little :3

made this in a day xd

@TacticalTechJay TacticalTechJay marked this pull request as ready for review May 10, 2024 06:34
@diced
Copy link
Owner

diced commented May 23, 2024

getting this in logs when changing password and accessing another link on zipline while in a incognito window

2024-05-22 09:06:57,720 PM debug [withZipline] Cannot read properties of null (reading 'sessions')

Screenshot_20240522_210849

@TacticalTechJay TacticalTechJay marked this pull request as draft July 13, 2024 00:49
@TacticalTechJay
Copy link
Collaborator Author

Drafted cuz I'll be spending a looot of time figuring it out.

@TacticalTechJay TacticalTechJay marked this pull request as ready for review July 13, 2024 01:53
@TacticalTechJay
Copy link
Collaborator Author

Screw it, we ballin'. Give this one a try

@diced
Copy link
Owner

diced commented Jul 15, 2024

Seems like it works but when a session is invalidated, you can still navigate through the dashboard but all the API calls fail with "not logged in"

@diced
Copy link
Owner

diced commented Sep 2, 2024

Closing this since it's being implemented in v4 but differently.

@diced diced closed this Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Session doesn't invalidate when password is changed
2 participants