Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor C++ Test Drivers #18

Open
emcd opened this issue Feb 9, 2013 · 6 comments
Open

Refactor C++ Test Drivers #18

emcd opened this issue Feb 9, 2013 · 6 comments

Comments

@emcd
Copy link
Contributor

emcd commented Feb 9, 2013

The C++ test drivers consist of a lot of copy pasta, which violates the DRY principle. These should be cleaned up and have common functionality factored out to improve future maintainability and extensibility.

@ghost ghost assigned emcd Feb 9, 2013
@mr-c
Copy link
Contributor

mr-c commented Mar 12, 2015

These are unused and have been so for a while. Perhaps they should be deleted?

@kdm9
Copy link
Contributor

kdm9 commented Mar 12, 2015

perhaps ping #788 ?

I'd love to have ./lib as a self-contained and installable library, as we're using it as such. Obviously sans the semver promises that apply to the python api. Removing crud would help :)

@camillescott
Copy link
Member

I was actually pondering a C++ test suite the other day -- a lot of my multithreading stuff is low level, and very difficult to test from Python without writing more CPython objects, which kind of defeats the purpose of simple tests by adding tons of extra glue code just to run them in the first place. Unfortunately, I have zero knowledge or experience with C++ testing libs. Thoughts @ctb, @mr-c @luizirber ?

@ctb
Copy link
Member

ctb commented Mar 19, 2015

On Thu, Mar 19, 2015 at 08:56:38AM -0700, Camille Scott wrote:

I was actually pondering a C++ test suite the other day -- a lot of my multithreading stuff is low level, and very difficult to test from Python without writing more CPython objects, which kind of defeats the purpose of simple tests by adding tons of extra glue code just to run them in the first place. Unfortunately, I have zero knowledge or experience with C++ testing libs. Thoughts @ctb, @mr-c @luizirber ?

I hear Boost has a testing lib.

@camillescott
Copy link
Member

growls

@kdm9
Copy link
Contributor

kdm9 commented Mar 20, 2015

This looks pretty cool:
https://github.com/philsquared/Catch

Header only, boost licensed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants