Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a screencast of what successful clone, compile + tests looks like #152

Open
ctb opened this issue Sep 3, 2013 · 20 comments
Open

Make a screencast of what successful clone, compile + tests looks like #152

ctb opened this issue Sep 3, 2013 · 20 comments
Milestone

Comments

@ctb
Copy link
Member

ctb commented Sep 3, 2013

@RamRS pointed out that it wasn't obvious ;)

@RamRS
Copy link
Contributor

RamRS commented Sep 3, 2013

Or, create a makeIt.sh that runs a make >out 2>err then picks up the last 2 lines, checks and displays success/failure!

@luizirber
Copy link
Member

You can use something like http://ascii.io/ too

On Mon, Sep 2, 2013 at 10:19 PM, Ram RS [email protected] wrote:

Or, create a makeIt.sh that runs a make >out 2>err then picks up the last
2 lines, checks and displays success/failure!


Reply to this email directly or view it on GitHubhttps://github.com//issues/152#issuecomment-23685058
.

@fishjord
Copy link
Contributor

fishjord commented Sep 3, 2013

or just check the exit code of make?

On Mon, Sep 2, 2013 at 9:19 PM, Ram RS [email protected] wrote:

Or, create a makeIt.sh that runs a make >out 2>err then picks up the last
2 lines, checks and displays success/failure!


Reply to this email directly or view it on GitHubhttps://github.com//issues/152#issuecomment-23685058
.

@fishjord
Copy link
Contributor

fishjord commented Sep 3, 2013

I think ascii.io would be a better choice than a screencast, unless you
were planning on having a lot of talking. It can be difficult to sync
audio to ascii.io (from what I've heard).

On Mon, Sep 2, 2013 at 9:23 PM, Luiz Irber [email protected] wrote:

You can use something like http://ascii.io/ too

On Mon, Sep 2, 2013 at 10:19 PM, Ram RS [email protected] wrote:

Or, create a makeIt.sh that runs a make >out 2>err then picks up the
last
2 lines, checks and displays success/failure!


Reply to this email directly or view it on GitHub<
https://github.com/ged-lab/khmer/issues/152#issuecomment-23685058>
.


Reply to this email directly or view it on GitHubhttps://github.com//issues/152#issuecomment-23685146
.

@mr-c
Copy link
Contributor

mr-c commented Oct 2, 2013

Will this be needed with the new build system?

@RamRS
Copy link
Contributor

RamRS commented Oct 2, 2013

Is it possible to implement an equivalent of make tests (or any make X)
with a deb? Assuming debs are installed with sudo apt-get, what will make X
translate to?

Ram

On Wed, Oct 2, 2013 at 3:39 PM, Michael R. Crusoe
[email protected]:

Will this be needed with the new build system?


Reply to this email directly or view it on GitHubhttps://github.com//issues/152#issuecomment-25570077
.

@mr-c
Copy link
Contributor

mr-c commented Oct 2, 2013

In the new build system the makefiles are going away.

Tests will be run from an unpacked tarball via python setup.py nosetests

I don't see how a Debian binary package would be of use to a developer.

@RamRS
Copy link
Contributor

RamRS commented Oct 2, 2013

Ahh, I was quite out of context, thinking of debs and rpms and whatnot! setup.py is what's being discussed and the issue now needs rephrasing:

On running "python setup.py nosetests"
How does one know if these tests ran successfully or failed? Also, amateur-alert.

@mr-c
Copy link
Contributor

mr-c commented Oct 2, 2013

There is a summary at the end

Ran 211 tests in 17.102s

OK

@ctb
Copy link
Member Author

ctb commented Oct 3, 2013

I like the notion of tests being runnable after install; could help debug
various issues. More discussion needed.

--titus

On Wed, Oct 02, 2013 at 12:44:12PM -0700, Ram RS wrote:

Is it possible to implement an equivalent of make tests (or any make X)
with a deb? Assuming debs are installed with sudo apt-get, what will make X
translate to?

Ram

On Wed, Oct 2, 2013 at 3:39 PM, Michael R. Crusoe
[email protected]:

Will this be needed with the new build system?

???
Reply to this email directly or view it on GitHubhttps://github.com//issues/152#issuecomment-25570077
.


Reply to this email directly or view it on GitHub:

#152 (comment)

C. Titus Brown, [email protected]

@RamRS
Copy link
Contributor

RamRS commented Oct 3, 2013

@ctb : Post-install testing mandatory or optional? Also, is this the default behavior when we run a "make test" after a "make all"?

@ctb
Copy link
Member Author

ctb commented Oct 6, 2013

Post-install optional, in case we are getting weird results due to architecture or other installs; it'd be nice to be able to ask the user to do some basic cross-checking. @mr-c may be able to reassure me that this is never needed with RPMs or DEBs... 'make test' runs the tests, but 'make all' does not.

@mr-c
Copy link
Contributor

mr-c commented Oct 8, 2013

Yes it would be useful to run the tests on the installed khmer and not the copy in the current directory. Right now we don't install the tests.

@mr-c mr-c mentioned this issue Mar 13, 2014
@RamRS
Copy link
Contributor

RamRS commented Mar 13, 2014

Do we have a non make test way of testing after install now? If not, how do we go about creating one?

@mr-c
Copy link
Contributor

mr-c commented Mar 16, 2014

Not at this time. For the purposes of this issue doing a git clone ...; cd khmer; make; make tests in a http://ascii.io/ recording would fulfill the request.

Testing after install is not a current priority.

@RamRS
Copy link
Contributor

RamRS commented Mar 16, 2014

Alright. I'm on it!

Ram
Sent from my Phone
On Mar 16, 2014 5:32 PM, "Michael R. Crusoe" [email protected]
wrote:

Not at this time. For the purposes of this issue doing a git clone ...;
cd khmer; make; make tests in a http://ascii.io/ recording would fulfill
the request.

Testing after install is not a current priority.

Reply to this email directly or view it on GitHubhttps://github.com//issues/152#issuecomment-37771707
.

@RamRS
Copy link
Contributor

RamRS commented Mar 17, 2014

How does this look? https://asciinema.org/a/8203

@mr-c
Copy link
Contributor

mr-c commented Mar 20, 2014

@RamRS Great!

@ctb What did you want done with the screencast?

@qingpeng
Copy link
Contributor

Good job!@RamRS https://github.com/RamRS

On Sun, Mar 16, 2014 at 8:58 PM, Ram RS [email protected] wrote:

How does this look? https://asciinema.org/a/8203

Reply to this email directly or view it on GitHubhttps://github.com//issues/152#issuecomment-37777668
.

@RamRS
Copy link
Contributor

RamRS commented Mar 21, 2014

Thank you. It was quite a straightforward task, and I am glad that you find
it satisfactory! :-)

Ram

On Thu, Mar 20, 2014 at 9:03 PM, Qingpeng Zhang [email protected]:

Good job!@RamRS https://github.com/RamRS

On Sun, Mar 16, 2014 at 8:58 PM, Ram RS [email protected] wrote:

How does this look? https://asciinema.org/a/8203

Reply to this email directly or view it on GitHub<
https://github.com/ged-lab/khmer/issues/152#issuecomment-37777668>

.

Reply to this email directly or view it on GitHubhttps://github.com//issues/152#issuecomment-38238917
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants