Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync table of ownage with Devilution master #12

Open
16 of 81 tasks
mewmew opened this issue Oct 17, 2019 · 3 comments
Open
16 of 81 tasks

sync table of ownage with Devilution master #12

mewmew opened this issue Oct 17, 2019 · 3 comments

Comments

@mewmew
Copy link
Contributor

mewmew commented Oct 17, 2019 •
edited
Loading

I wrote a little tool to diff the function name usage in Devilution vs. those defined in the table of ownage.

Most names are correct, but there are ~80 or so that needs to be update in surgery/function.md so they have the same name as that used in Devilution.

Note, a few of these may be false positives (e.g. CopyInt) as I ran the tool on DevilutionX/Source and those functions were introduced in DevilutionX for save file handling.

A set of function names related to rendering were recently updated as part of the cleanup in diasurgical/devilution#1802, so they should be easy to sync.

Oh, and I just realized, that a few functions are added to Devilution from the debug release of Diablo, so those will show up in the list as I only checked the v1.09b addresses of the surgery/functions.md table.

The list is as follows:

  • assert_fail
  • GiveGoldCheat (only in beta)
  • StoresCheat (only in beta)
  • TakeGoldCheat (only in beta)
  • MaxSpellsCheat (only in beta)
  • SetSpellLevelCheat
  • SetAllSpellsCheat
  • PrintDebugPlayer
  • PrintDebugQuest
  • PrintDebugMonster
  • GetDebugMonster
  • NextDebugMonster
  • diablo_init
  • diablo_splash
  • CelBlit
  • CelDraw
  • CelBlitFrame
  • CelClippedDraw
  • CelClippedBlit
  • CelBlitLight
  • CelBlitLightTrans
  • CelDrawLight
  • CelClippedDrawLight
  • CelClippedBlitLightTrans
  • CelDrawLightRed
  • CelBlitSafe
  • CelClippedDrawSafe
  • CelClippedBlitSafe
  • CelBlitLightSafe
  • CelBlitLightTransSafe
  • CelDrawLightSafe
  • CelClippedBlitLightTransSafe
  • CelDrawLightRedSafe
  • CelBlitWidth
  • CelBlitOutline
  • CelBlitOutlineSafe
  • Cl2Draw
  • Cl2Blit
  • Cl2DrawOutline
  • Cl2BlitOutline
  • Cl2DrawLightTbl
  • Cl2BlitLight
  • Cl2DrawLight
  • Cl2DrawSafe
  • Cl2BlitSafe
  • Cl2DrawOutlineSafe
  • Cl2BlitOutlineSafe
  • Cl2DrawLightTblSafe
  • Cl2BlitLightSafe
  • Cl2DrawLightSafe
  • ToggleLighting (only in beta)
  • CopyBytes (only in DevilutionX, as part of new save handling)
  • CopyChar (only in DevilutionX, as part of new save handling)
  • CopyShort (only in DevilutionX, as part of new save handling)
  • CopyShorts (only in DevilutionX, as part of new save handling)
  • CopyInt (only in DevilutionX, as part of new save handling)
  • CopyInts (only in DevilutionX, as part of new save handling)
  • CopyInt64 (only in DevilutionX, as part of new save handling)
  • LoadItemData
  • LoadItems
  • SaveItems
  • mpqapi_store_default_time
  • On_CHEAT_SPELL_LEVEL
  • On_DEBUG
  • dumphist
  • DeleteObject_ (present in functions.md but without the _ suffix)
  • AddBloodFtn
  • AddGoatShrine
  • AddCauldron
  • AddMurkyFountain
  • AddTearFountain
  • PM_DoStand
  • RenderLine
  • RenderTile
  • ScrollView (only in beta)
  • EnableFrameCount (only in beta)
  • DrawFPS (only in beta)
  • SHA1CircularShift
  • tmsg_start
  • town_special_lower
  • town_special_upper

P.S. if someone is curious, I can share the horrid tool that was used to produce this list :p I'm learning how to parse C++ as I go :)

(cc: @AJenbo as you are currently not listed as a watcher for updates to this repo ^^)
@AJenbo
Copy link
Member

AJenbo commented Oct 17, 2019 •
edited
Loading

Parsing thease files might be very helpful :)
https://github.com/diasurgical/devilution/tree/hellfire/comparer-config

P.s. Fine ill add one more project to my watch list

@mewmew
Copy link
Contributor Author

mewmew commented Oct 17, 2019 •
edited
Loading

Parsing thease files might be very helpful :)
https://github.com/diasurgical/devilution/tree/hellfire/comparer-config

I ran a diff against comparer-config/diablo.toml, which had a diff of ~40 functions:

  • assert_fail
  • GiveGoldCheat (only in beta)
  • StoresCheat (only in beta)
  • TakeGoldCheat (only in beta)
  • MaxSpellsCheat (only in beta)
  • SetSpellLevelCheat
  • SetAllSpellsCheat
  • PrintDebugPlayer
  • PrintDebugQuest
  • PrintDebugMonster
  • GetDebugMonster
  • NextDebugMonster
  • diablo_init
  • diablo_splash
  • ToggleLighting (only in beta)
  • CopyBytes (only in DevilutionX, as part of new save handling)
  • CopyChar (only in DevilutionX, as part of new save handling)
  • CopyShort (only in DevilutionX, as part of new save handling)
  • CopyShorts (only in DevilutionX, as part of new save handling)
  • CopyInt (only in DevilutionX, as part of new save handling)
  • CopyInts (only in DevilutionX, as part of new save handling)
  • CopyInt64 (only in DevilutionX, as part of new save handling)
  • LoadItemData
  • LoadItems
  • SaveItems
  • mpqapi_store_default_time
  • dumphist
  • AddBloodFtn
  • AddGoatShrine
  • AddCauldron
  • AddMurkyFountain
  • AddTearFountain
  • AddBrnCross
  • RenderLine
  • RenderTile
  • ScrollView (only in beta)
  • EnableFrameCount (only in beta)
  • DrawFPS (only in beta)
  • SHA1CircularShift
  • tmsg_start
  • town_special_lower
  • town_special_upper

@AJenbo
Copy link
Member

AJenbo commented Oct 17, 2019

RenderTile and RenderLine are DevilutionX only as well, they replace drawUpperScreen and drawLowerScreen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AJenbo @mewmew