Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue Report]: (Android) Item destroyed when placed during lag #7152

Open
sdm519 opened this issue Jun 22, 2024 · 4 comments
Open

[Issue Report]: (Android) Item destroyed when placed during lag #7152

sdm519 opened this issue Jun 22, 2024 · 4 comments

Comments

@sdm519
Copy link

sdm519 commented Jun 22, 2024

Operating System

Android

DevilutionX version

1.5.2

Describe

Items disappear and are essentially destroyed if placed at same time as a lag spike.

After picking up an item from your inventory, it will change your cursor until you place an item down in inventory, equip it, or drop it out of inventory. If you click to place it down at the same time as a lag spike, the cursor reverts to normal, the item disappears and is permanently gone.

To Reproduce

  1. Join game on ZeroNet with user that causes a lag spike every 5-10 seconds.
  2. Open inventory and pick up an item so it becomes your cursor
  3. Place the item back down in an open spot in the inventory at the exact moment of a lag spike
  4. Notice the cursor reverts and the item permanently disappears

Expected Behavior

The cursor does not revert until the item is placed. Items should never spontaneously disappear.

Additional context

Related to similar issue #7151 (comment)

My suspicion is that cursors lose their current state if the state attempts to change at the moment a lag spike occurs. There are likely more manifestations of this.

@StephenCWills
Copy link
Member

Reproduced in a TCP game using a gamepad on Windows x64.

@ErickN13
Copy link

Isso aconteceu comigo hoje!

@qndel
Copy link
Member

qndel commented Jun 25, 2024

Isso aconteceu comigo hoje!

we speak english here, so either comment in english or don't comment at all

@ErickN13
Copy link

Ok bro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants