Small QOL improvmeent - allow returning values from streaming handlers

dialohq · Apr 17, 2024 · 9313451 · 9313451
1 parent 1a0e2be
commit 9313451
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/lib/eio/client/client.ml b/lib/eio/client/client.ml
@@ -68,7 +68,7 @@ let bidirectional_streaming (type headers response conn_error) ~sw
               }
             in
 
-            let () =
+            let res =
               f ~writer ~take:(fun () ->
                   match Eio.Stream.take reader with
                   | None -> None
@@ -85,7 +85,7 @@ let bidirectional_streaming (type headers response conn_error) ~sw
             | None -> (
                 let status = Eio.Promise.await grpc_status in
                 match Grpc.Status.code status with
-                | Grpc.Status.OK -> Ok ()
+                | Grpc.Status.OK -> Ok res
                 | _ -> Error (`Rpc (response, status))))
           else Error (`Rpc (response, Eio.Promise.await grpc_status))
       | Error e -> Error (`Connection e))

diff --git a/lib/eio/client/client.mli b/lib/eio/client/client.mli
@@ -65,5 +65,5 @@ val bidirectional_streaming :
   decode:(string -> ('response, 'decoding_error) result) ->
   encode:('request -> string) ->
   headers:Grpc_client.request_headers ->
-  (writer:'request writer -> take:(unit -> 'response option) -> unit) ->
-  (unit, 'decoding_error, 'conn_error, 'net_response) rpc_result
+  (writer:'request writer -> take:(unit -> 'response option) -> 'a) ->
+  ('a, 'decoding_error, 'conn_error, 'net_response) rpc_result