Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When the scummvm repository updates and is pulled locally, 'make' on this repository build dir builds incorrectly #5

Open
i30817 opened this issue Mar 30, 2022 · 4 comments

Comments

@i30817
Copy link
Contributor

i30817 commented Mar 30, 2022

What happens is that make says it built the new changes, and then fails at runtime with a missing or incorrect symbol (from the new upstream code).

The obvious solution is, of course, call make clean before if the parent repository had a update.

However, i believe it would be valuable to automate this so that the build make file here can handle this cause automatically, because it makes automation complicated otherwise, or waste a lot of cpu and electricity rebuilding sub-modules it doesn't need by always calling make clean.

I don't know the best way to do this, if it's better to make this a submodule of the main project or what, just reporting.

@i30817 i30817 closed this as completed Mar 30, 2022
@i30817 i30817 reopened this Mar 30, 2022
@i30817
Copy link
Contributor Author

i30817 commented Mar 31, 2022

This might help, although i'm not sure it's the same issue.

@ner00
Copy link
Contributor

ner00 commented Jun 18, 2022

I seem to have the same "issue", @i30817 did you ever resolve this to prevent cleaning and rebuilding after pulling?

@i30817
Copy link
Contributor Author

i30817 commented Jun 18, 2022

No, i didn't manage to solve it. To tell the truth, i didn't even try.

@ner00
Copy link
Contributor

ner00 commented Jun 18, 2022

I was too lazy to try your suggestion above - that's why I asked - ahah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants