Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rather than using DOM to access elements, separate components should be created. #18

Open
rajneesh069 opened this issue Dec 31, 2023 · 13 comments
Assignees

Comments

@rajneesh069
Copy link

rajneesh069 commented Dec 31, 2023

Since we are using React.js as our front-end framework hence we should create different components for different UI elements rather than using DOM to access/manipulate them as it makes things confusing as it depicts that those elements are in the static index.html file but in reality they are just being returned inside the main WeatherApp function inside "WeatherApp.jsx".
I am attaching relevant screenshots here. Please look into it.

@rajneesh069 rajneesh069 changed the title Rather than using dom to access elements, separate components should be created. Rather than using DOM to access elements, separate components should be created. Dec 31, 2023
@rajneesh069
Copy link
Author

Screenshot from 2023-12-31 19-47-28

@TejasSathe010
Copy link

I can fix this issue if not yet fixed or assigned to anyone. Thank you!

@dhruvabhat24
Copy link
Owner

@rajneesh069 I have assigned it to you.

@rajneesh069
Copy link
Author

@rajneesh069 I have assigned it to you.

Okay, I'll work on it. Although I'll need some time to work on it as I am occupied with my own project right now.

@dhruvabhat24
Copy link
Owner

Okay take your time

@Ceejay-777
Copy link
Contributor

Hi. The useref() hook is used to access elements right? In my opinion, it would be a great idea to employ that.

@Ceejay-777
Copy link
Contributor

Hi, good day. Can I work on this? I should be done with it soon.

@dhruvabhat24
Copy link
Owner

Okay I will assign it to you

@DeeKoders
Copy link
Contributor

If this issue is still open, i'll work on it. Please assign it to me if still available.

@dhruvabhat24
Copy link
Owner

@DeeKoders Sorry for the delay this task is assigned to you and you can work on it

@DeeKoders
Copy link
Contributor

@DeeKoders Sorry for the delay this task is assigned to you and you can work on it

on it

@DeeKoders
Copy link
Contributor

@dhruvabhat24 The issue seems to be resolved. Can you verify it and close the issue

@dhruvabhat24
Copy link
Owner

Okay Let me check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants