You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm solving an issue in my app for building tables in PDF and found strange code in the method DrawRow of the Table class. Please look on the code snippet:
// if it is not header row or first row in the table then remove row's
// top border
if (row != header && row != rows.get(0)) {
if (!isEndOfPage(row)) {
row.removeTopBorders();
}
}
here is the row variable compared to header. I'm not so deep in java, but they have different types - row is Row and header is List. Could you please double check that it is correct?
I assumed that this comparison can be removed at all - so top borders can be removed if this row is not first and it is not EndOfPage.
The text was updated successfully, but these errors were encountered:
You are right! row != header is redundant and makes no sense but we need this part of the code beacause not only that we need to check if row is not first row, we need to check if current row is part of the header rows. That need to be changed and I mark this as a bug.
Hello everyone,
I'm solving an issue in my app for building tables in PDF and found strange code in the method DrawRow of the Table class. Please look on the code snippet:
here is the row variable compared to header. I'm not so deep in java, but they have different types - row is Row and header is List. Could you please double check that it is correct?
I assumed that this comparison can be removed at all - so top borders can be removed if this row is not first and it is not EndOfPage.
The text was updated successfully, but these errors were encountered: