-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Names in Metadata #351
Comments
I think we're calling nameparser's capitalize method incorrectly - putting a pin in this with this comment to come back - see, e.g., I don't think this stuff in name_parser.py does quite what we want it to:
Poked around a little, and I think the thing to do is to set all of the name fields and then run name.capitalize() on the whole thing to modify it in place, and then extract name.last, name.first, and name.middle. Will take a proper look tmrw. |
whereas...
... which does seem off, but there you go. I'll fix and make a PR. |
[2019-05-13 -- this comment replaced with updated list below] |
Computation Center phone directory records from 1955-56 will help address some of these; we'll have these visually tomorrow. |
For some reason @erica02139 's latest edited list sent by email didn't get attached to this issue. Here it is, replacing my comment above:
|
Thanks, @ryaanahmed! Have done more; will post tonight: also, here are Computation Center directory records from 1956-1963: will post on Slack, too. |
Perfect -- I just went over and took lots of pictures of the area. Will make a story. |
|
I'm removing this from the deploy-ready milestone. At this point, it looks to me like we've cleaned most of the truly wrong metadata; there's still some sleuthing to do around many of the 'unknown' first-name folks, but this can become ongoing project maintenance work and work for the summer. |
There are some duplicates left in our metadata sheet.
Here's a list of likely candidates to look into.
If you have either checked or fixed a last name, please add it here so I can update the list.
The text was updated successfully, but these errors were encountered: