Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C4GT] Asset: Add tests for UnauthorizedOperation #368

Open
3 tasks
vatsa287 opened this issue Mar 12, 2024 · 4 comments · May be fixed by #521
Open
3 tasks

[C4GT] Asset: Add tests for UnauthorizedOperation #368

vatsa287 opened this issue Mar 12, 2024 · 4 comments · May be fixed by #521
Assignees
@Om-Thorat
Labels
C4GT Community good first issue Good for newcomers

Comments

@vatsa287
Copy link
Member

vatsa287 commented Mar 12, 2024 •
edited
Loading

Description

Subtask under : cord-network/community#7

New testcase can be tested under cargo test -p pallet-asset after adding it in the code.

Goals

  • Add tests for UnauthorizedOperation for pallet/asset

Expected Outcome

  • Test should assert for UnauthorizedOperation being returned properly in all the possible calls.
  • If there are more than one function returning this error code, all of them should be validated either as one test case or as multiple test cases.

Acceptance Criteria

NA

Implementation Details

Look at other test cases, and add a test case for the same.
Ex: check method asset_create_should_succeed which validates creation of asset.

Mockups / Wireframes

NA

Product Name

CORD

Organization Name

Dhiway

Domain

Blockchain

Tech Skills Needed

Rust

Mentor(s)

@amarts @vatsa287

Complexity

[Medium]

Category

[Test]

Sub Category

[Beginner friendly]
@ninja-mayank ninja-mayank mentioned this issue Mar 13, 2024
Closed
@ninja-mayank
Copy link

Hello @vatsa287 , I would like to contribute to ticket #368, Can you please assign it to me

@VishnuAmit
Copy link

Hey @vatsa287 I have raised a PR. Kindly look into it.

Pratik-050 added a commit to Pratik-050/cord that referenced this issue May 2, 2024
@Pratik-050
fixes: dhiway#368
670d556 
Details:
Created a new function  asset_create_unauthorized_operation to generate  an asset with invalid authorization. Handled the error
@Pratik-050 Pratik-050 mentioned this issue May 2, 2024
Open
Pratik-050 added a commit to Pratik-050/cord that referenced this issue May 3, 2024
@Pratik-050
fixes: dhiway#368
0047ff3 
Details:
Created a new function  asset_create_unauthorized_operation to generate  an asset with invalid authorization. Handled the error
Pratik-050 added a commit to Pratik-050/cord that referenced this issue May 3, 2024
@Pratik-050
fixes: dhiway#368
5f82493 
Details:
Created a new function  asset_create_unauthorized_operation to generate  an asset with invalid authorization. Handled the error
@vatsa287 vatsa287 mentioned this issue May 6, 2024
Closed
Pratik-050 added a commit to Pratik-050/cord that referenced this issue May 6, 2024
@Pratik-050
fixes: dhiway#368
066dd7e 
Details:
Created a new function  asset_create_unauthorized_operation to generate  an asset with invalid authorization. Handled the error
Pratik-050 added a commit to Pratik-050/cord that referenced this issue May 6, 2024
@Pratik-050
fixes: dhiway#368
f297090 
Details:
Created a new function  asset_create_unauthorized_operation to generate  an asset with invalid authorization. Handled the error
@Om-Thorat
Copy link

Om-Thorat commented Nov 6, 2024 •
edited
Loading

Hey @vatsa287 @amarts, I would like to work on this Issue. I have observed all the ways UnauthorizedOperation could be returned in pallet/asset and have also looked at other relevant tests for the same functions such as asset_create_should_succeed and setup & compiled the project on local.

Do let me know if i can start working on it :)

@vatsa287
Copy link
Member Author

vatsa287 commented Nov 7, 2024

@Om-Thorat Sure you can take this up.

@Om-Thorat Om-Thorat linked a pull request Nov 7, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Om-Thorat Om-Thorat

Labels
C4GT Community good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
4 participants
@vatsa287 @Om-Thorat @ninja-mayank @VishnuAmit