From 5237c66ffa372ca79eb28c55369cefc7d4eab327 Mon Sep 17 00:00:00 2001 From: Mohammer5 Date: Mon, 15 Jul 2024 10:41:23 +0200 Subject: [PATCH 1/4] fix(icon types): export IconSubtract16 & IconSubtract24 --- icons/types/index.d.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/icons/types/index.d.ts b/icons/types/index.d.ts index 29c0295caa..7141db5983 100644 --- a/icons/types/index.d.ts +++ b/icons/types/index.d.ts @@ -184,6 +184,8 @@ export const IconSubscribe16: React.FC export const IconSubscribe24: React.FC export const IconSubscribeOff16: React.FC export const IconSubscribeOff24: React.FC +export const IconSubtract16: React.FC +export const IconSubtract24: React.FC export const IconSubtractCircle16: React.FC export const IconSubtractCircle24: React.FC export const IconSync16: React.FC From c059fde8e511c21c8540a418833a98b2f868eb6e Mon Sep 17 00:00:00 2001 From: Mohammer5 Date: Mon, 15 Jul 2024 11:19:09 +0200 Subject: [PATCH 2/4] fix(menu item types): make suffix prop optional --- components/menu/types/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/components/menu/types/index.d.ts b/components/menu/types/index.d.ts index 44d646cee8..bd99c82440 100644 --- a/components/menu/types/index.d.ts +++ b/components/menu/types/index.d.ts @@ -80,7 +80,7 @@ export interface MenuItemProps { /** * A supporting element shown at the end of the menu item */ - suffix: React.ReactNode + suffix?: React.ReactNode tabIndex?: number /** * For using menu item as a link From bc59cf769d24ac66061b78424db0732f164ce387 Mon Sep 17 00:00:00 2001 From: Mohammer5 Date: Mon, 15 Jul 2024 11:19:35 +0200 Subject: [PATCH 3/4] fix(modal types): accept ReactNodes as children --- components/modal/src/modal-title/modal-title.js | 2 +- components/modal/types/index.d.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/components/modal/src/modal-title/modal-title.js b/components/modal/src/modal-title/modal-title.js index 5ac103b05a..95c32c2c1c 100644 --- a/components/modal/src/modal-title/modal-title.js +++ b/components/modal/src/modal-title/modal-title.js @@ -26,6 +26,6 @@ ModalTitle.defaultProps = { } ModalTitle.propTypes = { - children: PropTypes.string, + children: PropTypes.node, dataTest: PropTypes.string, } diff --git a/components/modal/types/index.d.ts b/components/modal/types/index.d.ts index ac9673c8bf..601f493717 100644 --- a/components/modal/types/index.d.ts +++ b/components/modal/types/index.d.ts @@ -36,7 +36,7 @@ export interface ModalContentProps { export const ModalContent: React.FC export interface ModalTitleProps { - children?: string + children?: React.ReactNode dataTest?: string } From c093a14988da636a88bc9ce2c5e7589a5a7e8f80 Mon Sep 17 00:00:00 2001 From: Mohammer5 Date: Mon, 15 Jul 2024 11:19:44 +0200 Subject: [PATCH 4/4] fix(tag types): accept ReactNodes as children --- components/tag/src/tag.js | 2 +- components/tag/types/index.d.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/components/tag/src/tag.js b/components/tag/src/tag.js index 6520fed456..34bf4d8d43 100644 --- a/components/tag/src/tag.js +++ b/components/tag/src/tag.js @@ -102,7 +102,7 @@ Tag.defaultProps = { Tag.propTypes = { /** Use bold tags where it is important that the tag is seen by the user in an information dense interface. Bold tags should be reserved for edge cases and not overused. */ bold: PropTypes.bool, - children: PropTypes.string, + children: PropTypes.node, className: PropTypes.string, dataTest: PropTypes.string, /** Tags can contain icons. Use icons where they will help users easily identify the content of the tag. Tags must have a text label and cannot display only an icon. */ diff --git a/components/tag/types/index.d.ts b/components/tag/types/index.d.ts index 2a66f9ee9b..518da25947 100644 --- a/components/tag/types/index.d.ts +++ b/components/tag/types/index.d.ts @@ -5,7 +5,7 @@ export interface TagProps { * Use bold tags where it is important that the tag is seen by the user in an information dense interface. Bold tags should be reserved for edge cases and not overused. */ bold?: boolean - children?: string + children?: React.ReactNode className?: string dataTest?: string /**