From fd5696d128c3a225853e70b703d01d21d27a85b4 Mon Sep 17 00:00:00 2001
From: Jen Jones Arnesen <jennifer@dhis2.org>
Date: Tue, 27 Jun 2023 14:07:47 +0200
Subject: [PATCH] chore: use 50 second timeout for card title to appear (#2730)

The "add event layer" test continues to be flaky.
This change increases the timeout to 50 seconds.
Also, since the default timeout is now 15 seconds, the EXTENDED_TIMOUT
option isn't needed anymore (since that also sets to 15 seconds)
---
 cypress/elements/layer.js | 20 ++++++++------------
 1 file changed, 8 insertions(+), 12 deletions(-)

diff --git a/cypress/elements/layer.js b/cypress/elements/layer.js
index 9d3b6b284..cddd9680a 100644
--- a/cypress/elements/layer.js
+++ b/cypress/elements/layer.js
@@ -1,12 +1,10 @@
-import { EXTENDED_TIMEOUT } from '../support/util.js'
-
 export class Layer {
     openDialog(layer) {
         const dataTest = `addlayeritem-${layer
             .toLowerCase()
             .replace(/\s/g, '_')}`
 
-        cy.getByDataTest('add-layer-button', EXTENDED_TIMEOUT).click()
+        cy.getByDataTest('add-layer-button').click()
 
         cy.get(`[data-test="${dataTest}"]`).click()
 
@@ -51,38 +49,36 @@ export class Layer {
     }
 
     addToMap() {
-        cy.getByDataTest('dhis2-uicore-modalactions', EXTENDED_TIMEOUT)
+        cy.getByDataTest('dhis2-uicore-modalactions')
             .contains('Add layer')
             .click()
     }
 
     validateDialogClosed(closed) {
         if (closed) {
-            cy.getByDataTest('layeredit', EXTENDED_TIMEOUT).should('not.exist')
+            cy.getByDataTest('layeredit').should('not.exist')
         } else {
-            cy.getByDataTest('layeredit', EXTENDED_TIMEOUT).should('be.visible')
+            cy.getByDataTest('layeredit').should('be.visible')
         }
     }
 
     validateCardTitle(title) {
-        cy.getByDataTest('layercard', EXTENDED_TIMEOUT)
-            .contains(title, EXTENDED_TIMEOUT)
+        cy.getByDataTest('layercard')
+            .contains(title, { timeout: 50000 })
             .should('be.visible')
 
         return this
     }
 
     validateCardPeriod(period) {
-        cy.getByDataTest('layercard', EXTENDED_TIMEOUT)
-            .contains(period)
-            .should('be.visible')
+        cy.getByDataTest('layercard').contains(period).should('be.visible')
 
         return this
     }
 
     validateCardItems(items) {
         items.forEach((item) => {
-            cy.getByDataTest('layercard', EXTENDED_TIMEOUT)
+            cy.getByDataTest('layercard')
                 .find('[data-test="layerlegend-item"]')
                 .contains(item)
                 .should('be.visible')