- {i18n.t('No menu items found for')}
- {filter}
+ {i18n.t('No menu items found for')} ‘{filter}’
)
From 7e5b7a7319ab8f904ac608807843b710cc8a618c Mon Sep 17 00:00:00 2001
From: Joseph John Aas Cooper <33054985+cooper-joe@users.noreply.github.com>
Date: Tue, 17 Dec 2024 09:02:08 +0100
Subject: [PATCH 15/18] fix: adjust org unit row height, expand button
---
.../list/OrganisationUnitList.module.css | 9 +++++++++
src/pages/organisationUnits/list/OrganisationUnitRow.tsx | 3 ++-
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/src/pages/organisationUnits/list/OrganisationUnitList.module.css b/src/pages/organisationUnits/list/OrganisationUnitList.module.css
index b841b32f..662a77cd 100644
--- a/src/pages/organisationUnits/list/OrganisationUnitList.module.css
+++ b/src/pages/organisationUnits/list/OrganisationUnitList.module.css
@@ -1,6 +1,10 @@
.expandButton {
border: 0 !important;
}
+.expandButton:hover {
+ background-color: var(--colors-grey300) !important;
+ color: var(--colors-grey900) !important;
+}
.listDetailsWrapper {
display: grid;
@@ -12,6 +16,11 @@
margin-top: var(--spacers-dp8);
}
+.orgUnitRow td {
+ padding-block-start: var(--spacers-dp8);
+ padding-block-end: var(--spacers-dp8);
+}
+
@media (max-width: 1200px) {
.listDetailsWrapper {
display: grid;
diff --git a/src/pages/organisationUnits/list/OrganisationUnitRow.tsx b/src/pages/organisationUnits/list/OrganisationUnitRow.tsx
index 49b740bc..ddcaccc4 100644
--- a/src/pages/organisationUnits/list/OrganisationUnitRow.tsx
+++ b/src/pages/organisationUnits/list/OrganisationUnitRow.tsx
@@ -37,7 +37,7 @@ export const OrganisationUnitRow = ({
return (
<>
-
+
Date: Tue, 17 Dec 2024 09:49:52 +0100
Subject: [PATCH 16/18] fix: adjust help and description texts
---
src/components/form/attributes/CustomAttributes.tsx | 2 +-
src/components/form/fields/ShortNameField.tsx | 2 +-
src/pages/categories/form/CategoryFormFields.tsx | 8 +++-----
src/pages/categoryCombos/form/CategoryComboFormFields.tsx | 8 +++++---
.../form/CategoryOptionComboFormFields.tsx | 4 +++-
.../form/CategoryOptionGroupSetFormFields.tsx | 6 +++---
.../form/CategoryOptionGroupFormFields.tsx | 4 ++--
.../categoryOptions/form/CategoryOptionFormFields.tsx | 2 +-
.../form/DataElementGroupSetFormFields.tsx | 4 ++--
.../dataElementGroups/form/DataElementGroupFormFields.tsx | 2 +-
src/pages/dataElements/fields/AggregationLevelsField.tsx | 3 ---
src/pages/dataElements/fields/CategoryComboField.tsx | 2 +-
src/pages/dataElements/fields/OptionSetCommentField.tsx | 2 +-
src/pages/dataElements/fields/OptionSetField.tsx | 2 +-
src/pages/dataElements/fields/UrlField.tsx | 2 +-
src/pages/dataElements/form/DataElementFormFields.tsx | 6 +++---
16 files changed, 29 insertions(+), 30 deletions(-)
diff --git a/src/components/form/attributes/CustomAttributes.tsx b/src/components/form/attributes/CustomAttributes.tsx
index 08d2e2b4..b40a247d 100644
--- a/src/components/form/attributes/CustomAttributes.tsx
+++ b/src/components/form/attributes/CustomAttributes.tsx
@@ -121,7 +121,7 @@ export function CustomAttributesSection({
{i18n.t(
- 'Set up information for the attributes assigned to {{modelName}}',
+ 'Set up information for the attributes assigned to {{modelName}}.',
{ modelName: schemaSection.titlePlural.toLowerCase() }
)}
diff --git a/src/components/form/fields/ShortNameField.tsx b/src/components/form/fields/ShortNameField.tsx
index fa257132..e3f22730 100644
--- a/src/components/form/fields/ShortNameField.tsx
+++ b/src/components/form/fields/ShortNameField.tsx
@@ -49,7 +49,7 @@ export function ShortNameField({
})
const helpString =
- helpText || i18n.t('Often used in reports where space is limited')
+ helpText || i18n.t('Often used in reports where space is limited.')
return (
diff --git a/src/pages/categories/form/CategoryFormFields.tsx b/src/pages/categories/form/CategoryFormFields.tsx
index 1e261bae..d6730ca5 100644
--- a/src/pages/categories/form/CategoryFormFields.tsx
+++ b/src/pages/categories/form/CategoryFormFields.tsx
@@ -42,7 +42,7 @@ export const CategoryFormFields = () => {
{i18n.t(
- 'Choose how this category option group will be used to capture and analyze'
+ 'Choose how this category option group will be used to capture and analyze data.'
)}
@@ -72,7 +72,7 @@ export const CategoryFormFields = () => {
component={CheckboxFieldFF}
label={i18n.t('Use as data dimension')}
helpText={i18n.t(
- 'Category option group will be available to the analytics as another dimension'
+ 'Make available to analytics apps as a selectable dimension.'
)}
/>
@@ -85,9 +85,7 @@ export const CategoryFormFields = () => {
- {i18n.t(
- 'Choose the category options to include in this category option group.'
- )}
+ {i18n.t('Choose the options to include in this category.')}
diff --git a/src/pages/categoryCombos/form/CategoryComboFormFields.tsx b/src/pages/categoryCombos/form/CategoryComboFormFields.tsx
index 298f3f7a..114df371 100644
--- a/src/pages/categoryCombos/form/CategoryComboFormFields.tsx
+++ b/src/pages/categoryCombos/form/CategoryComboFormFields.tsx
@@ -26,7 +26,9 @@ export const CategoryComboFormFields = () => {
{i18n.t('Basic information')}
- {i18n.t('Set up the basic information for this category.')}
+ {i18n.t(
+ 'Set up the basic information for this category combination.'
+ )}
@@ -43,7 +45,7 @@ export const CategoryComboFormFields = () => {
{i18n.t(
- 'Choose how this category combo will be used to capture and analyze data.'
+ 'Choose how this category combination will be used to capture and analyze data.'
)}
@@ -84,7 +86,7 @@ export const CategoryComboFormFields = () => {
{i18n.t(
- 'Choose the categories to include in this category combo.'
+ 'Choose the categories to include in this category combination.'
)}
diff --git a/src/pages/categoryOptionCombos/form/CategoryOptionComboFormFields.tsx b/src/pages/categoryOptionCombos/form/CategoryOptionComboFormFields.tsx
index 68fbfad3..d11af6f0 100644
--- a/src/pages/categoryOptionCombos/form/CategoryOptionComboFormFields.tsx
+++ b/src/pages/categoryOptionCombos/form/CategoryOptionComboFormFields.tsx
@@ -22,7 +22,9 @@ export const CategoryOptionComboFormFields = () => {
{i18n.t('Basic information')}
- {i18n.t('Set up the basic information for this category.')}
+ {i18n.t(
+ 'Set up the basic information for this category option combination.'
+ )}
diff --git a/src/pages/categoryOptionGroupSets/form/CategoryOptionGroupSetFormFields.tsx b/src/pages/categoryOptionGroupSets/form/CategoryOptionGroupSetFormFields.tsx
index a1b6b704..6a9f1e65 100644
--- a/src/pages/categoryOptionGroupSets/form/CategoryOptionGroupSetFormFields.tsx
+++ b/src/pages/categoryOptionGroupSets/form/CategoryOptionGroupSetFormFields.tsx
@@ -43,7 +43,7 @@ function CategoryOptionGroupSetFormFields() {
{i18n.t(
- 'Choose how this category option group set will be used to capture and analyze'
+ 'Choose how this category option group set will be used to capture and analyze data.'
)}
@@ -73,7 +73,7 @@ function CategoryOptionGroupSetFormFields() {
component={CheckboxFieldFF}
label={i18n.t('Use as data dimension')}
helpText={i18n.t(
- 'Category option group set will be available to the analytics as another dimension'
+ 'Make available to analytics apps as a selectable dimension.'
)}
/>
@@ -82,7 +82,7 @@ function CategoryOptionGroupSetFormFields() {
diff --git a/src/pages/categoryOptionGroups/form/CategoryOptionGroupFormFields.tsx b/src/pages/categoryOptionGroups/form/CategoryOptionGroupFormFields.tsx
index 2c5ca915..8f4ad85e 100644
--- a/src/pages/categoryOptionGroups/form/CategoryOptionGroupFormFields.tsx
+++ b/src/pages/categoryOptionGroups/form/CategoryOptionGroupFormFields.tsx
@@ -43,7 +43,7 @@ function CategoryOptionGroupFormFields() {
{i18n.t(
- 'Choose how this category option will be used to capture and analyze'
+ 'Choose how this category option will be used to capture and analyze data.'
)}
@@ -76,7 +76,7 @@ function CategoryOptionGroupFormFields() {
{i18n.t(
- 'Choose the category options to include in this category.'
+ 'Choose the options to include in this category option group.'
)}
diff --git a/src/pages/categoryOptions/form/CategoryOptionFormFields.tsx b/src/pages/categoryOptions/form/CategoryOptionFormFields.tsx
index 2d015116..6af8e337 100644
--- a/src/pages/categoryOptions/form/CategoryOptionFormFields.tsx
+++ b/src/pages/categoryOptions/form/CategoryOptionFormFields.tsx
@@ -55,7 +55,7 @@ export const CategoryOptionFormFields = () => {
{i18n.t(
- 'Choose when, and for which organisation units this category option will be available.'
+ 'Choose when, and for which organisation units, this category option will be available.'
)}
diff --git a/src/pages/dataElementGroupSets/form/DataElementGroupSetFormFields.tsx b/src/pages/dataElementGroupSets/form/DataElementGroupSetFormFields.tsx
index da4d5502..d68be089 100644
--- a/src/pages/dataElementGroupSets/form/DataElementGroupSetFormFields.tsx
+++ b/src/pages/dataElementGroupSets/form/DataElementGroupSetFormFields.tsx
@@ -30,7 +30,7 @@ export function DataElementGroupSetFormFields() {
{i18n.t(
- 'Set up the information for this data element group'
+ 'Set up the information for this data element group set.'
)}
@@ -40,7 +40,7 @@ export function DataElementGroupSetFormFields() {
diff --git a/src/pages/dataElementGroups/form/DataElementGroupFormFields.tsx b/src/pages/dataElementGroups/form/DataElementGroupFormFields.tsx
index b52cace5..0c61cbca 100644
--- a/src/pages/dataElementGroups/form/DataElementGroupFormFields.tsx
+++ b/src/pages/dataElementGroups/form/DataElementGroupFormFields.tsx
@@ -26,7 +26,7 @@ export function DataElementGroupFormFields() {
{i18n.t(
- 'Set up the information for this data element group'
+ 'Set up the information for this data element group.'
)}
diff --git a/src/pages/dataElements/fields/AggregationLevelsField.tsx b/src/pages/dataElements/fields/AggregationLevelsField.tsx
index 4f372083..bab3173d 100644
--- a/src/pages/dataElements/fields/AggregationLevelsField.tsx
+++ b/src/pages/dataElements/fields/AggregationLevelsField.tsx
@@ -38,9 +38,6 @@ export function AggregationLevelsField() {
diff --git a/src/pages/dataElements/form/DataElementFormFields.tsx b/src/pages/dataElements/form/DataElementFormFields.tsx
index 4826c55f..ec7da6b0 100644
--- a/src/pages/dataElements/form/DataElementFormFields.tsx
+++ b/src/pages/dataElements/form/DataElementFormFields.tsx
@@ -40,7 +40,7 @@ export function DataElementFormFields() {
- {i18n.t('Set up the information for this data element')}
+ {i18n.t('Set up the information for this data element.')}
@@ -126,7 +126,7 @@ export function DataElementFormFields() {
{i18n.t(
- 'Visualize values for this data element in Analytics app. Multiple legendSet can be applied.'
+ 'Visualize values for this data element in Analytics app. Multiple legends can be applied.'
)}
@@ -142,7 +142,7 @@ export function DataElementFormFields() {
{i18n.t(
- 'By default, the aggregation will start at the lowest assigned organisation unit. If you for example select "Chiefdom", it means that "Chiefdom", "District" and "National" aggregates use "Chiefdom" (the highest aggregation level available) as the data source, and PHU data will not be included. PHU will still be available for the PHU level, but not included in the aggregations to the levels above.'
+ 'By default, aggregation starts at the lowest assigned organisation unit. You can override this by choosing a different level. Choosing a higher level means that data from lower levels will not be included in the aggregation.'
)}
From d15315637b796e0bb2ff55a4d1bedb5a1ca902de Mon Sep 17 00:00:00 2001
From: Joseph John Aas Cooper <33054985+cooper-joe@users.noreply.github.com>
Date: Tue, 17 Dec 2024 09:59:21 +0100
Subject: [PATCH 17/18] fix: data element group transfers sizing
---
.../DataElementGroupsTransfer/DataElementGroupsTransfer.tsx | 3 +++
.../DataElementsTransfer/DataElementsTransfer.tsx | 3 +++
.../fields/DataElementGroupsField.module.css | 2 +-
3 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/src/components/metadataFormControls/DataElementGroupsTransfer/DataElementGroupsTransfer.tsx b/src/components/metadataFormControls/DataElementGroupsTransfer/DataElementGroupsTransfer.tsx
index 7ac44e19..417010cf 100644
--- a/src/components/metadataFormControls/DataElementGroupsTransfer/DataElementGroupsTransfer.tsx
+++ b/src/components/metadataFormControls/DataElementGroupsTransfer/DataElementGroupsTransfer.tsx
@@ -148,6 +148,9 @@ export const DataElementGroupsTransfer = forwardRef(
rightFooter={rightFooter}
leftHeader={leftHeader}
leftFooter={leftFooter}
+ height="320px"
+ optionsWidth="480px"
+ selectedWidth="480px"
/>
)
}
diff --git a/src/components/metadataFormControls/DataElementsTransfer/DataElementsTransfer.tsx b/src/components/metadataFormControls/DataElementsTransfer/DataElementsTransfer.tsx
index b5e3481e..f1afb148 100644
--- a/src/components/metadataFormControls/DataElementsTransfer/DataElementsTransfer.tsx
+++ b/src/components/metadataFormControls/DataElementsTransfer/DataElementsTransfer.tsx
@@ -145,6 +145,9 @@ export const DataElementsTransfer = forwardRef(function DataElementsSelect(
rightFooter={rightFooter}
leftHeader={leftHeader}
leftFooter={leftFooter}
+ height="320px"
+ optionsWidth="480px"
+ selectedWidth="480px"
/>
)
})
diff --git a/src/pages/dataElementGroupSets/fields/DataElementGroupsField.module.css b/src/pages/dataElementGroupSets/fields/DataElementGroupsField.module.css
index f40ea288..cb604490 100644
--- a/src/pages/dataElementGroupSets/fields/DataElementGroupsField.module.css
+++ b/src/pages/dataElementGroupSets/fields/DataElementGroupsField.module.css
@@ -1,4 +1,4 @@
-.dataElementsOptionsFooter {
+.dataElementGroupsOptionsFooter {
padding: var(--spacers-dp8) 0;
}
From f0e6d18327f4f6afa8fa79907893de51bbaaeca8 Mon Sep 17 00:00:00 2001
From: Joseph John Aas Cooper <33054985+cooper-joe@users.noreply.github.com>
Date: Tue, 17 Dec 2024 10:17:11 +0100
Subject: [PATCH 18/18] fix: ou-tree field styling
---
.../fields/OrganisationUnitField.module.css | 8 ++++++++
.../form/fields/OrganisationUnitField.tsx | 17 ++++++++++-------
2 files changed, 18 insertions(+), 7 deletions(-)
create mode 100644 src/components/form/fields/OrganisationUnitField.module.css
diff --git a/src/components/form/fields/OrganisationUnitField.module.css b/src/components/form/fields/OrganisationUnitField.module.css
new file mode 100644
index 00000000..2b25b25b
--- /dev/null
+++ b/src/components/form/fields/OrganisationUnitField.module.css
@@ -0,0 +1,8 @@
+.OrganisationUnitTreeWrapper {
+ padding: var(--spacers-dp4);
+ border: 1px solid var(--colors-grey300);
+ border-radius: 3px;
+ width: 640px;
+ max-height: 800px;
+ overflow: auto;
+}
diff --git a/src/components/form/fields/OrganisationUnitField.tsx b/src/components/form/fields/OrganisationUnitField.tsx
index c65bff26..46bf1c6b 100644
--- a/src/components/form/fields/OrganisationUnitField.tsx
+++ b/src/components/form/fields/OrganisationUnitField.tsx
@@ -7,6 +7,7 @@ import {
import React from 'react'
import { useField } from 'react-final-form'
import { useCurrentUserRootOrgUnits } from '../../../lib/user/currentUserStore'
+import classes from './OrganisationUnitField.module.css'
type OrganisationUnitFieldProps = {
name?: string
@@ -66,13 +67,15 @@ export const OrganisationUnitField = ({
error={meta.touched && meta.error}
validationText={meta.touched && meta.error}
>
-
+