From 7868787176c41229480eb1becf16430bb223db9d Mon Sep 17 00:00:00 2001
From: Martin Ohlson <martin@moid.se>
Date: Mon, 26 Feb 2024 15:45:58 +0000
Subject: [PATCH] refactor: use strings directly instead of wrapping in an
 object

---
 .../Dialogs/Conditions/AlphanumericCondition.js        |  4 ++--
 src/components/Dialogs/Conditions/ConditionsManager.js |  2 +-
 src/components/Dialogs/Conditions/DateCondition.js     |  2 +-
 src/components/Dialogs/Conditions/NumericCondition.js  |  4 ++--
 src/components/Dialogs/Conditions/OrgUnitCondition.js  |  2 +-
 src/components/Dialogs/Conditions/RepeatableEvents.js  |  4 ++--
 src/components/Dialogs/DynamicDimension.js             |  2 +-
 src/components/Dialogs/FixedDimension.js               |  4 ++--
 .../Dialogs/PeriodDimension/PeriodDimension.js         |  2 +-
 src/components/Dialogs/PeriodDimension/StartEndDate.js |  4 ++--
 src/components/Dialogs/common/TransferLeftHeader.js    |  2 +-
 src/components/MainSidebar/MainDimensions.js           |  2 +-
 src/components/MainSidebar/MainSidebar.js              |  2 +-
 .../ProgramDimensionsPanel/ProgramDimensions.js        |  2 +-
 .../ProgramDimensionsPanel/ProgramDimensionsFilter.js  |  2 +-
 .../MainSidebar/ProgramDimensionsPanel/StageFilter.js  |  2 +-
 .../MainSidebar/ProgramDimensionsPanel/StageSelect.js  |  2 +-
 .../MainSidebar/ProgramDimensionsPanel/TypeSelect.js   |  2 +-
 .../MainSidebar/TrackedEntityDimensionsMenuItem.js     |  2 +-
 .../TrackedEntityDimensionsPanel.js                    |  4 ++--
 .../YourDimensionsPanel/YourDimensionsPanel.js         |  4 ++--
 src/components/Visualization/Visualization.js          | 10 +++++-----
 .../VisualizationOptions/Options/LegendDisplayStyle.js |  2 +-
 .../VisualizationOptions/Options/ShowLegendKey.js      |  2 +-
 24 files changed, 35 insertions(+), 35 deletions(-)

diff --git a/src/components/Dialogs/Conditions/AlphanumericCondition.js b/src/components/Dialogs/Conditions/AlphanumericCondition.js
index bfd9f3b16..c1c6545c1 100644
--- a/src/components/Dialogs/Conditions/AlphanumericCondition.js
+++ b/src/components/Dialogs/Conditions/AlphanumericCondition.js
@@ -83,7 +83,7 @@ const BaseCondition = ({
                             key={key}
                             value={key}
                             label={value}
-                            dataTest={'alphanumeric-condition-type'}
+                            dataTest="alphanumeric-condition-type"
                         />
                     )
                 )}
@@ -105,7 +105,7 @@ const BaseCondition = ({
                         onChange={({ checked }) => toggleCaseSensitive(checked)}
                         dense
                         className={classes.caseSensitiveCheckbox}
-                        dataTest={'condition-case-sensitive-checkbox'}
+                        dataTest="condition-case-sensitive-checkbox"
                     />
                 )}
             <Button
diff --git a/src/components/Dialogs/Conditions/ConditionsManager.js b/src/components/Dialogs/Conditions/ConditionsManager.js
index f38bad812..5886bb70e 100644
--- a/src/components/Dialogs/Conditions/ConditionsManager.js
+++ b/src/components/Dialogs/Conditions/ConditionsManager.js
@@ -482,7 +482,7 @@ const ConditionsManager = ({
                             content={i18n.t(
                                 'Only available for repeatable stages'
                             )}
-                            dataTest={'repeatable-events-tooltip'}
+                            dataTest="repeatable-events-tooltip"
                         >
                             {repeatableTab}
                         </Tooltip>
diff --git a/src/components/Dialogs/Conditions/DateCondition.js b/src/components/Dialogs/Conditions/DateCondition.js
index 1337d4b61..01c0919e9 100644
--- a/src/components/Dialogs/Conditions/DateCondition.js
+++ b/src/components/Dialogs/Conditions/DateCondition.js
@@ -55,7 +55,7 @@ const BaseCondition = ({ condition, onChange, onRemove, type, max }) => {
                         key={key}
                         value={key}
                         label={value}
-                        dataTest={'date-condition-type'}
+                        dataTest="date-condition-type"
                     />
                 ))}
             </SingleSelectField>
diff --git a/src/components/Dialogs/Conditions/NumericCondition.js b/src/components/Dialogs/Conditions/NumericCondition.js
index 8afe30f93..ba91c1668 100644
--- a/src/components/Dialogs/Conditions/NumericCondition.js
+++ b/src/components/Dialogs/Conditions/NumericCondition.js
@@ -132,7 +132,7 @@ const NumericCondition = ({
                         key={key}
                         value={key}
                         label={value}
-                        dataTest={'numeric-condition-type'}
+                        dataTest="numeric-condition-type"
                     />
                 ))}
                 <MenuDivider dense />
@@ -141,7 +141,7 @@ const NumericCondition = ({
                     value={OPERATOR_IN}
                     label={i18n.t('is one of preset options')}
                     disabled={numberOfConditions > 1}
-                    dataTest={'numeric-condition-type'}
+                    dataTest="numeric-condition-type"
                 />
             </SingleSelectField>
             {operator &&
diff --git a/src/components/Dialogs/Conditions/OrgUnitCondition.js b/src/components/Dialogs/Conditions/OrgUnitCondition.js
index bce7e1927..fe94be4fc 100644
--- a/src/components/Dialogs/Conditions/OrgUnitCondition.js
+++ b/src/components/Dialogs/Conditions/OrgUnitCondition.js
@@ -67,7 +67,7 @@ const OrgUnitCondition = ({
             ].filter((path) => path)}
             selected={selected.path && [selected.path]}
             onChange={(item) => setValues(item)}
-            dataTest={'org-unit-tree'}
+            dataTest="org-unit-tree"
             singleSelection
         />
     )
diff --git a/src/components/Dialogs/Conditions/RepeatableEvents.js b/src/components/Dialogs/Conditions/RepeatableEvents.js
index b419dc75f..d023f8a6c 100644
--- a/src/components/Dialogs/Conditions/RepeatableEvents.js
+++ b/src/components/Dialogs/Conditions/RepeatableEvents.js
@@ -86,7 +86,7 @@ const RepeatableEvents = ({ dimensionId }) => {
                         value={mostRecent.toString()}
                         onChange={({ value }) => onMostRecentChange(value)}
                         min="0"
-                        dataTest={'most-recent-input'}
+                        dataTest="most-recent-input"
                     />
                 </div>
                 <div className={classes.repeatableWrapper}>
@@ -103,7 +103,7 @@ const RepeatableEvents = ({ dimensionId }) => {
                         value={oldest.toString()}
                         onChange={({ value }) => onOldestChange(value)}
                         min="0"
-                        dataTest={'oldest-input'}
+                        dataTest="oldest-input"
                     />
                 </div>
             </div>
diff --git a/src/components/Dialogs/DynamicDimension.js b/src/components/Dialogs/DynamicDimension.js
index 795bf97a9..15de30aee 100644
--- a/src/components/Dialogs/DynamicDimension.js
+++ b/src/components/Dialogs/DynamicDimension.js
@@ -194,7 +194,7 @@ const DynamicDimension = ({
 
     return dimension ? (
         <DimensionModal
-            dataTest={'dynamic-dimension-modal'}
+            dataTest="dynamic-dimension-modal"
             isInLayout={isInLayout}
             onClose={closeModal}
             title={dimension.name}
diff --git a/src/components/Dialogs/FixedDimension.js b/src/components/Dialogs/FixedDimension.js
index 06249eac4..f78761eef 100644
--- a/src/components/Dialogs/FixedDimension.js
+++ b/src/components/Dialogs/FixedDimension.js
@@ -156,7 +156,7 @@ const FixedDimension = ({
                             }
                             dense
                             className={classes.verticalCheckbox}
-                            dataTest={'program-status-checkbox'}
+                            dataTest="program-status-checkbox"
                         />
                     ))}
                 </div>
@@ -199,7 +199,7 @@ const FixedDimension = ({
                             }
                             dense
                             className={classes.verticalCheckbox}
-                            dataTest={'event-status-checkbox'}
+                            dataTest="event-status-checkbox"
                         />
                     ))}
                 </div>
diff --git a/src/components/Dialogs/PeriodDimension/PeriodDimension.js b/src/components/Dialogs/PeriodDimension/PeriodDimension.js
index 54fd84219..b08259605 100644
--- a/src/components/Dialogs/PeriodDimension/PeriodDimension.js
+++ b/src/components/Dialogs/PeriodDimension/PeriodDimension.js
@@ -171,7 +171,7 @@ export const PeriodDimension = ({ dimension, onClose }) => {
 
     return dimension ? (
         <DimensionModal
-            dataTest={'period-dimension-modal'}
+            dataTest="period-dimension-modal"
             isInLayout={isInLayout}
             onClose={onClose}
             title={dimension.name}
diff --git a/src/components/Dialogs/PeriodDimension/StartEndDate.js b/src/components/Dialogs/PeriodDimension/StartEndDate.js
index 320d4c97f..0dc8b54d8 100644
--- a/src/components/Dialogs/PeriodDimension/StartEndDate.js
+++ b/src/components/Dialogs/PeriodDimension/StartEndDate.js
@@ -36,7 +36,7 @@ export const StartEndDate = ({
                     label={i18n.t('Start date')}
                     inputWidth="200px"
                     max="9999-12-31"
-                    dataTest={'start-date-input'}
+                    dataTest="start-date-input"
                 />
                 <div className={styles.icon}>
                     <IconArrowRight16 color={colors.grey500} />
@@ -48,7 +48,7 @@ export const StartEndDate = ({
                     label={i18n.t('End date')}
                     inputWidth="200px"
                     max="9999-12-31"
-                    dataTest={'end-date-input'}
+                    dataTest="end-date-input"
                 />
             </div>
         </Field>
diff --git a/src/components/Dialogs/common/TransferLeftHeader.js b/src/components/Dialogs/common/TransferLeftHeader.js
index 72c08713d..1d6d603bd 100644
--- a/src/components/Dialogs/common/TransferLeftHeader.js
+++ b/src/components/Dialogs/common/TransferLeftHeader.js
@@ -16,7 +16,7 @@ export const TransferLeftHeader = ({ searchTerm, setSearchTerm, dataTest }) => (
             dataTest={`${dataTest}-filter-input-field`}
             dense
             initialFocus
-            type={'search'}
+            type="search"
         />
     </div>
 )
diff --git a/src/components/MainSidebar/MainDimensions.js b/src/components/MainSidebar/MainDimensions.js
index e70e27fc2..e59fc4a30 100644
--- a/src/components/MainSidebar/MainDimensions.js
+++ b/src/components/MainSidebar/MainDimensions.js
@@ -18,7 +18,7 @@ export const MainDimensions = () => {
     return (
         <MainSidebarSection
             header={i18n.t('Global dimensions')}
-            dataTest={'main-dimensions-sidebar'}
+            dataTest="main-dimensions-sidebar"
         >
             {draggableDimensions.map((dimension) => (
                 <span className={styles.span} key={dimension.id}>
diff --git a/src/components/MainSidebar/MainSidebar.js b/src/components/MainSidebar/MainSidebar.js
index 4cd5d88fb..5d1bb0505 100644
--- a/src/components/MainSidebar/MainSidebar.js
+++ b/src/components/MainSidebar/MainSidebar.js
@@ -134,7 +134,7 @@ const MainSidebar = () => {
                 )}
                 {!(selectedProgramId || selectedEntityTypeId) ? (
                     <Tooltip
-                        dataTest={'no-input-tooltip'}
+                        dataTest="no-input-tooltip"
                         content={i18n.t('Choose an input first')}
                         closeDelay={0}
                         placement="bottom"
diff --git a/src/components/MainSidebar/ProgramDimensionsPanel/ProgramDimensions.js b/src/components/MainSidebar/ProgramDimensionsPanel/ProgramDimensions.js
index 90dda453b..88591edb5 100644
--- a/src/components/MainSidebar/ProgramDimensionsPanel/ProgramDimensions.js
+++ b/src/components/MainSidebar/ProgramDimensionsPanel/ProgramDimensions.js
@@ -22,7 +22,7 @@ export const ProgramDimensions = () => {
     return (
         <MainSidebarSection
             header={i18n.t('Program dimensions')}
-            dataTest={'program-dimensions'}
+            dataTest="program-dimensions"
         >
             {draggableDimensions.map((dimension) => (
                 <span key={dimension.id} className={styles.span}>
diff --git a/src/components/MainSidebar/ProgramDimensionsPanel/ProgramDimensionsFilter.js b/src/components/MainSidebar/ProgramDimensionsPanel/ProgramDimensionsFilter.js
index 39e815b45..9d030b6ed 100644
--- a/src/components/MainSidebar/ProgramDimensionsPanel/ProgramDimensionsFilter.js
+++ b/src/components/MainSidebar/ProgramDimensionsPanel/ProgramDimensionsFilter.js
@@ -56,7 +56,7 @@ const ProgramDimensionsFilter = ({
             value={searchTerm}
             onChange={({ value }) => setSearchTerm(value)}
             dense
-            type={'search'}
+            type="search"
             placeholder={i18n.t('Search data dimensions')}
         />
         <SingleSelect
diff --git a/src/components/MainSidebar/ProgramDimensionsPanel/StageFilter.js b/src/components/MainSidebar/ProgramDimensionsPanel/StageFilter.js
index 42bafbd5f..55e53d7b4 100644
--- a/src/components/MainSidebar/ProgramDimensionsPanel/StageFilter.js
+++ b/src/components/MainSidebar/ProgramDimensionsPanel/StageFilter.js
@@ -20,7 +20,7 @@ const StageFilter = ({ stages, selected, setSelected }) => {
             dense
             selected={selected || STAGE_ALL}
             onChange={onChange}
-            dataTest={'stage-select'}
+            dataTest="stage-select"
         >
             <SingleSelectOption label={i18n.t('All')} value={STAGE_ALL} />
             {stages.map(({ id, name }) => (
diff --git a/src/components/MainSidebar/ProgramDimensionsPanel/StageSelect.js b/src/components/MainSidebar/ProgramDimensionsPanel/StageSelect.js
index 4f79632fd..e667d7ad1 100644
--- a/src/components/MainSidebar/ProgramDimensionsPanel/StageSelect.js
+++ b/src/components/MainSidebar/ProgramDimensionsPanel/StageSelect.js
@@ -32,7 +32,7 @@ const StageSelect = ({ stages }) => {
                         dense
                         selected={selectedStageId}
                         onChange={onChange}
-                        dataTest={'stage-select'}
+                        dataTest="stage-select"
                         filterable
                         noMatchText={i18n.t('No stages found')}
                     >
diff --git a/src/components/MainSidebar/ProgramDimensionsPanel/TypeSelect.js b/src/components/MainSidebar/ProgramDimensionsPanel/TypeSelect.js
index 5b9e83297..532916465 100644
--- a/src/components/MainSidebar/ProgramDimensionsPanel/TypeSelect.js
+++ b/src/components/MainSidebar/ProgramDimensionsPanel/TypeSelect.js
@@ -68,7 +68,7 @@ const TypeSelect = () => {
                         onChange={({ selected }) => setSelectedTypeId(selected)}
                         placeholder={i18n.t('Choose a type')}
                         maxHeight="max(60vh, 460px)"
-                        dataTest={'type-select'}
+                        dataTest="type-select"
                         filterable
                         noMatchText={i18n.t('No types found')}
                         loading={fetching}
diff --git a/src/components/MainSidebar/TrackedEntityDimensionsMenuItem.js b/src/components/MainSidebar/TrackedEntityDimensionsMenuItem.js
index 91e20052a..175fce6ce 100644
--- a/src/components/MainSidebar/TrackedEntityDimensionsMenuItem.js
+++ b/src/components/MainSidebar/TrackedEntityDimensionsMenuItem.js
@@ -18,7 +18,7 @@ export const TrackedEntityDimensionsMenuItem = ({
         onClick={onClick}
         selected={selected}
         count={count}
-        dataTest={'tracked-entity-button'}
+        dataTest="tracked-entity-button"
     />
 )
 
diff --git a/src/components/MainSidebar/TrackedEntityDimensionsPanel/TrackedEntityDimensionsPanel.js b/src/components/MainSidebar/TrackedEntityDimensionsPanel/TrackedEntityDimensionsPanel.js
index b7b7ca764..832fcfd97 100644
--- a/src/components/MainSidebar/TrackedEntityDimensionsPanel/TrackedEntityDimensionsPanel.js
+++ b/src/components/MainSidebar/TrackedEntityDimensionsPanel/TrackedEntityDimensionsPanel.js
@@ -51,8 +51,8 @@ const TrackedEntityDimensionsPanel = ({ visible }) => {
                     onChange={({ value }) => setSearchTerm(value)}
                     dense
                     placeholder={i18n.t('Search dimensions')}
-                    type={'search'}
-                    dataTest={'search-te-dimension-input'}
+                    type="search"
+                    dataTest="search-te-dimension-input"
                 />
                 <div className={styles.programSelect}>
                     <ProgramFilter
diff --git a/src/components/MainSidebar/YourDimensionsPanel/YourDimensionsPanel.js b/src/components/MainSidebar/YourDimensionsPanel/YourDimensionsPanel.js
index 741a23eec..72539114f 100644
--- a/src/components/MainSidebar/YourDimensionsPanel/YourDimensionsPanel.js
+++ b/src/components/MainSidebar/YourDimensionsPanel/YourDimensionsPanel.js
@@ -40,8 +40,8 @@ const YourDimensionsPanel = ({ visible }) => {
                     onChange={({ value }) => setSearchTerm(value)}
                     dense
                     placeholder={i18n.t('Search your dimensions')}
-                    type={'search'}
-                    dataTest={'search-dimension-input'}
+                    type="search"
+                    dataTest="search-dimension-input"
                 />
             </div>
             <DimensionsList
diff --git a/src/components/Visualization/Visualization.js b/src/components/Visualization/Visualization.js
index 91eabc25e..ee32370e3 100644
--- a/src/components/Visualization/Visualization.js
+++ b/src/components/Visualization/Visualization.js
@@ -444,7 +444,7 @@ export const Visualization = ({
                       )
                     : undefined
             }
-            dataTest={'table-cell'}
+            dataTest="table-cell"
         >
             <div
                 style={
@@ -544,7 +544,7 @@ export const Visualization = ({
                                                 sizeClass,
                                                 'bordered'
                                             )}
-                                            dataTest={'table-header'}
+                                            dataTest="table-header"
                                         >
                                             {formatCellHeader(header)}
                                         </DataTableColumnHeader>
@@ -558,18 +558,18 @@ export const Visualization = ({
                                                 fontSizeClass,
                                                 sizeClass
                                             )}
-                                            dataTest={'table-header'}
+                                            dataTest="table-header"
                                         />
                                     )
                                 )}
                             </DataTableRow>
                         </DataTableHead>
                         {/* https://jira.dhis2.org/browse/LIBS-278 */}
-                        <DataTableBody dataTest={'table-body'}>
+                        <DataTableBody dataTest="table-body">
                             {data.rows.map((row, rowIndex) => (
                                 <DataTableRow
                                     key={rowIndex}
-                                    dataTest={'table-row'}
+                                    dataTest="table-row"
                                 >
                                     {row.map((value, columnIndex) =>
                                         cellIsUndefined(
diff --git a/src/components/VisualizationOptions/Options/LegendDisplayStyle.js b/src/components/VisualizationOptions/Options/LegendDisplayStyle.js
index d869b4573..b8453f8e9 100644
--- a/src/components/VisualizationOptions/Options/LegendDisplayStyle.js
+++ b/src/components/VisualizationOptions/Options/LegendDisplayStyle.js
@@ -20,7 +20,7 @@ const LegendDisplayStyle = () => (
                 label: i18n.t('Legend changes text color'),
             },
         ]}
-        dataTest={'legend-display-style'}
+        dataTest="legend-display-style"
     />
 )
 
diff --git a/src/components/VisualizationOptions/Options/ShowLegendKey.js b/src/components/VisualizationOptions/Options/ShowLegendKey.js
index f3e57312d..056c8f412 100644
--- a/src/components/VisualizationOptions/Options/ShowLegendKey.js
+++ b/src/components/VisualizationOptions/Options/ShowLegendKey.js
@@ -9,7 +9,7 @@ const ShowLegendKey = () => (
         option={{
             name: OPTION_SHOW_LEGEND_KEY,
         }}
-        dataTest={'option-legend-key'}
+        dataTest="option-legend-key"
     />
 )