From 2d1e4894c203edd0838814596b95fe59a3dd42ba Mon Sep 17 00:00:00 2001 From: martinkrulltott Date: Wed, 6 Sep 2023 15:43:02 +0200 Subject: [PATCH 1/2] fix: change labels for legend options --- i18n/en.pot | 12 ++++++------ .../Options/LegendDisplayStrategy.js | 6 ++---- 2 files changed, 8 insertions(+), 10 deletions(-) diff --git a/i18n/en.pot b/i18n/en.pot index 148b9e9dcb..8e76313004 100644 --- a/i18n/en.pot +++ b/i18n/en.pot @@ -5,8 +5,8 @@ msgstr "" "Content-Type: text/plain; charset=utf-8\n" "Content-Transfer-Encoding: 8bit\n" "Plural-Forms: nplurals=2; plural=(n != 1)\n" -"POT-Creation-Date: 2023-05-30T12:32:59.044Z\n" -"PO-Revision-Date: 2023-05-30T12:32:59.044Z\n" +"POT-Creation-Date: 2023-09-06T13:41:14.540Z\n" +"PO-Revision-Date: 2023-09-06T13:41:14.540Z\n" msgid "All items" msgstr "All items" @@ -480,11 +480,11 @@ msgstr "Legend style" msgid "Legend type" msgstr "Legend type" -msgid "Use pre-defined legend per data item" -msgstr "Use pre-defined legend per data item" +msgid "Use pre-defined legend by data item" +msgstr "Use pre-defined legend by data item" -msgid "Select a single legend for the entire visualization" -msgstr "Select a single legend for the entire visualization" +msgid "Select a legend" +msgstr "Select a legend" msgid "Legend changes background color" msgstr "Legend changes background color" diff --git a/src/components/VisualizationOptions/Options/LegendDisplayStrategy.js b/src/components/VisualizationOptions/Options/LegendDisplayStrategy.js index 535318158a..44ee0b5a33 100644 --- a/src/components/VisualizationOptions/Options/LegendDisplayStrategy.js +++ b/src/components/VisualizationOptions/Options/LegendDisplayStrategy.js @@ -18,7 +18,7 @@ const LegendDisplayStrategy = ({ value, onChange }) => ( ( /> Date: Mon, 2 Oct 2023 09:03:56 +0200 Subject: [PATCH 2/2] test: update strings in cypress --- cypress/elements/optionsModal/legend.js | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/cypress/elements/optionsModal/legend.js b/cypress/elements/optionsModal/legend.js index 3331ab98f3..4036add064 100644 --- a/cypress/elements/optionsModal/legend.js +++ b/cypress/elements/optionsModal/legend.js @@ -20,15 +20,12 @@ export const toggleLegend = () => .click() export const changeDisplayStrategyToFixed = () => - cy - .getBySel(optionsModalContentEl) - .contains('Select a single legend for the entire visualization') - .click() + cy.getBySel(optionsModalContentEl).contains('Select a legend').click() export const changeDisplayStrategyToByDataItem = () => cy .getBySel(optionsModalContentEl) - .contains('Use pre-defined legend per data item') + .contains('Use pre-defined legend by data item') .click() export const changeDisplayStyleToText = () =>