From ecad66713e34e03d11fb195f8b49d3e5e3b5ac5c Mon Sep 17 00:00:00 2001 From: Jen Jones Arnesen Date: Mon, 16 Oct 2023 11:27:32 +0200 Subject: [PATCH 1/2] chore: disable the e2e tests since v36 is no longer supported --- .github/workflows/verify.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/verify.yml b/.github/workflows/verify.yml index 3df80cbfa..1efc36100 100644 --- a/.github/workflows/verify.yml +++ b/.github/workflows/verify.yml @@ -101,10 +101,11 @@ jobs: - name: Test run: yarn test + # v36 is no longer supported, so do not run e2e tests e2e: runs-on: ubuntu-latest needs: install - if: "!contains(github.event.head_commit.message, '[skip ci]')" + if: false strategy: matrix: @@ -152,7 +153,7 @@ jobs: publish: runs-on: ubuntu-latest - needs: [build, lint, test, e2e] + needs: [build, lint, test] if: "!contains(github.event.head_commit.message, '[skip ci]')" steps: - uses: actions/checkout@v2 From 38806ba92f1301df6ead84eda429739cf16e3096 Mon Sep 17 00:00:00 2001 From: Jen Jones Arnesen Date: Mon, 16 Oct 2023 12:39:15 +0200 Subject: [PATCH 2/2] chore: improve comment --- .github/workflows/verify.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/verify.yml b/.github/workflows/verify.yml index 1efc36100..9f3cca800 100644 --- a/.github/workflows/verify.yml +++ b/.github/workflows/verify.yml @@ -101,7 +101,7 @@ jobs: - name: Test run: yarn test - # v36 is no longer supported, so do not run e2e tests + # v36 is no longer supported, so set the if condition to false to skip this job e2e: runs-on: ubuntu-latest needs: install