@@ -28,7 +22,6 @@ const ViewTitleBar = ({
{showDescription && (
)}
- {}
)
}
@@ -36,7 +29,6 @@ const ViewTitleBar = ({
ViewTitleBar.propTypes = {
displayDescription: PropTypes.string,
displayName: PropTypes.string,
- id: PropTypes.string,
showDescription: PropTypes.bool,
}
diff --git a/src/pages/view/TitleBar/styles/ActionsBar.module.css b/src/pages/view/TitleBar/styles/ActionsBar.module.css
index a7005736e..a0e8d71ea 100644
--- a/src/pages/view/TitleBar/styles/ActionsBar.module.css
+++ b/src/pages/view/TitleBar/styles/ActionsBar.module.css
@@ -1,16 +1,17 @@
.actions {
display: flex;
align-items: center;
- margin-left: 8px;
+ justify-content: flex-end;
+ flex-wrap: wrap-reverse;
+ gap: 4px;
}
.strip {
display: flex;
- margin-left: var(--spacers-dp8);
-}
-
-.strip > * {
- margin-left: var(--spacers-dp8);
+ align-items: center;
+ justify-content: flex-end;
+ gap: var(--spacers-dp4);
+ flex-wrap: wrap;
}
.strip .moreButtonSmall {
diff --git a/src/pages/view/TitleBar/styles/Description.module.css b/src/pages/view/TitleBar/styles/Description.module.css
index 7e15b5100..dcaf78091 100644
--- a/src/pages/view/TitleBar/styles/Description.module.css
+++ b/src/pages/view/TitleBar/styles/Description.module.css
@@ -3,11 +3,11 @@
}
.noDesc {
- color: #888;
+ color: var(--colors-grey600);
}
.descContainer {
- font-size: 14px;
- padding-top: 5px;
- padding-bottom: 5px;
+ font-size: 13px;
+ line-height: 17px;
+ padding: 0;
}
diff --git a/src/pages/view/TitleBar/styles/FilterSelector.module.css b/src/pages/view/TitleBar/styles/FilterSelector.module.css
index 7300c0839..2bca80a4f 100644
--- a/src/pages/view/TitleBar/styles/FilterSelector.module.css
+++ b/src/pages/view/TitleBar/styles/FilterSelector.module.css
@@ -1,3 +1,8 @@
+.buttonContainer {
+ display: flex;
+ align-items: center;
+}
+
@media only screen and (max-width: 480px) {
.buttonContainer {
display: none;
diff --git a/src/pages/view/TitleBar/styles/LastUpdatedTag.module.css b/src/pages/view/TitleBar/styles/LastUpdatedTag.module.css
index 53eac8a04..00e7d731c 100644
--- a/src/pages/view/TitleBar/styles/LastUpdatedTag.module.css
+++ b/src/pages/view/TitleBar/styles/LastUpdatedTag.module.css
@@ -1,3 +1,3 @@
.lastUpdatedTag {
- margin-top: var(--spacers-dp8);
+ margin-top: 0;
}
diff --git a/src/pages/view/TitleBar/styles/StarDashboardButton.module.css b/src/pages/view/TitleBar/styles/StarDashboardButton.module.css
index e4933be01..b925f8ae4 100644
--- a/src/pages/view/TitleBar/styles/StarDashboardButton.module.css
+++ b/src/pages/view/TitleBar/styles/StarDashboardButton.module.css
@@ -1,13 +1,34 @@
.star {
- margin: 0 0 0 var(--spacers-dp4);
- padding: 0;
+ margin: 0;
+ display: inline-flex;
+ align-items: center;
+ justify-content: center;
+ vertical-align: middle;
+ border-radius: 3px;
+ padding: 2px;
border: none;
- position: relative;
- top: 1px;
background: transparent;
+ position: relative;
outline: none;
cursor: pointer;
}
.star:disabled {
cursor: not-allowed;
}
+.star:hover {
+ background: var(--colors-grey300);
+}
+.starIcon {
+ width: 24px;
+ height: 24px;
+ display: block;
+}
+.starIcon svg {
+ color: var(--colors-grey600);
+}
+.star:hover .starIcon svg {
+ color: var(--colors-grey700);
+}
+.star:active .starIcon svg {
+ color: var(--colors-grey900);
+}
diff --git a/src/pages/view/TitleBar/styles/TitleBar.module.css b/src/pages/view/TitleBar/styles/TitleBar.module.css
index e58ed4cb9..88e0cc83f 100644
--- a/src/pages/view/TitleBar/styles/TitleBar.module.css
+++ b/src/pages/view/TitleBar/styles/TitleBar.module.css
@@ -1,26 +1,25 @@
.container {
- margin-top: var(--spacers-dp12);
+ /* margin-top: var(--spacers-dp12); */
+ background: var(--colors-white);
+ border-bottom: 1px solid var(--colors-grey400);
+ padding: var(--spacers-dp8) var(--spacers-dp8) var(--spacers-dp8)
+ var(--spacers-dp16);
+ position: sticky;
+ top: 0;
+ z-index: 10;
}
.titleBar {
display: flex;
- align-items: flex-start;
+ align-items: center;
+ justify-content: space-between;
position: relative;
}
.title {
position: relative;
- font-size: 21px;
+ font-size: 17px;
font-weight: 500;
- color: var(--colors-black);
- min-width: 50px;
- cursor: default;
+ color: var(--colors-grey900);
user-select: text;
- top: 7px;
-}
-
-@media only screen and (max-width: 480px) {
- .title {
- top: 3px;
- }
}
diff --git a/src/pages/view/ViewDashboard.js b/src/pages/view/ViewDashboard.js
index 286db9ffb..e0a5d289c 100644
--- a/src/pages/view/ViewDashboard.js
+++ b/src/pages/view/ViewDashboard.js
@@ -24,7 +24,6 @@ import { sGetDashboardById } from '../../reducers/dashboards.js'
import { sGetPassiveViewRegistered } from '../../reducers/passiveViewRegistered.js'
import { sGetSelectedId } from '../../reducers/selected.js'
import { ROUTE_START_PATH } from '../start/index.js'
-import FilterBar from './FilterBar/FilterBar.js'
import ItemGrid from './ItemGrid.js'
import classes from './styles/ViewDashboard.module.css'
import TitleBar from './TitleBar/TitleBar.js'
@@ -151,7 +150,6 @@ const ViewDashboard = (props) => {
) : (
<>
-
>
)
diff --git a/src/pages/view/__tests__/ViewDashboard.spec.js b/src/pages/view/__tests__/ViewDashboard.spec.js
index 5ac6c8791..66da9eff6 100644
--- a/src/pages/view/__tests__/ViewDashboard.spec.js
+++ b/src/pages/view/__tests__/ViewDashboard.spec.js
@@ -45,14 +45,6 @@ jest.mock(
}
)
-jest.mock(
- '../FilterBar/FilterBar',
- () =>
- function MockFilterBar() {
- return
MockFilterBar
- }
-)
-
jest.mock(
'../ItemGrid',
() =>
diff --git a/src/pages/view/__tests__/__snapshots__/ViewDashboard.spec.js.snap b/src/pages/view/__tests__/__snapshots__/ViewDashboard.spec.js.snap
index 0f1515cf9..0793eb28e 100644
--- a/src/pages/view/__tests__/__snapshots__/ViewDashboard.spec.js.snap
+++ b/src/pages/view/__tests__/__snapshots__/ViewDashboard.spec.js.snap
@@ -17,9 +17,6 @@ exports[`ViewDashboard renders dashboard 1`] = `
TitleBar
-
- MockFilterBar
-
MockItemGrid
diff --git a/src/pages/view/styles/ItemGrid.module.css b/src/pages/view/styles/ItemGrid.module.css
index b0a2e1368..d09ee77c8 100644
--- a/src/pages/view/styles/ItemGrid.module.css
+++ b/src/pages/view/styles/ItemGrid.module.css
@@ -1,3 +1,4 @@
.grid {
- margin-top: var(--spacers-dp16);
+ margin-top: var(--spacers-dp8);
+ padding: 0 var(--spacers-dp16);
}
diff --git a/yarn.lock b/yarn.lock
index 56f4f44f1..ea0a9c134 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -4418,12 +4418,7 @@ ansi-align@^3.0.0:
dependencies:
string-width "^3.0.0"
-ansi-colors@^4.1.1:
- version "4.1.1"
- resolved "https://registry.yarnpkg.com/ansi-colors/-/ansi-colors-4.1.1.tgz#cbb9ae256bf750af1eab344f229aa27fe94ba348"
- integrity sha512-JoX0apGbHaUJBNl6yF+p6JAFYZ666/hhCGKN5t9QFjbJQKUU/g8MNbFDbvfrgKXvI1QpZplPOnwIo99lX/AAmA==
-
-ansi-colors@^4.1.3:
+ansi-colors@^4.1.1, ansi-colors@^4.1.3:
version "4.1.3"
resolved "https://registry.yarnpkg.com/ansi-colors/-/ansi-colors-4.1.3.tgz#37611340eb2243e70cc604cad35d63270d48781b"
integrity sha512-/6w/C21Pm1A7aZitlI5Ni/2J6FFQN8i1Cvz3kHABAAbw93v/NlvKdVOqz7CCWz/3iv/JplRSEEZ83XION15ovw==
@@ -5809,7 +5804,12 @@ content-disposition@0.5.4:
dependencies:
safe-buffer "5.2.1"
-content-type@~1.0.4, content-type@~1.0.5:
+content-type@~1.0.4:
+ version "1.0.5"
+ resolved "https://registry.yarnpkg.com/content-type/-/content-type-1.0.5.tgz#8b773162656d1d1086784c8f23a54ce6d73d7918"
+ integrity sha512-nTjqfcBFEipKdXCv4YDQWCfmcLZKm81ldF0pAopTvyrFGVbcR6P/VAAd5G7N+0tTr8QqiU0tFadD6FK4NtJwOA==
+
+content-type@~1.0.5:
version "1.0.5"
resolved "https://registry.yarnpkg.com/content-type/-/content-type-1.0.5.tgz#8b773162656d1d1086784c8f23a54ce6d73d7918"
integrity sha512-nTjqfcBFEipKdXCv4YDQWCfmcLZKm81ldF0pAopTvyrFGVbcR6P/VAAd5G7N+0tTr8QqiU0tFadD6FK4NtJwOA==
@@ -6873,14 +6873,7 @@ error-ex@^1.3.1:
dependencies:
is-arrayish "^0.2.1"
-error-stack-parser@^2.0.6:
- version "2.0.6"
- resolved "https://registry.yarnpkg.com/error-stack-parser/-/error-stack-parser-2.0.6.tgz#5a99a707bd7a4c58a797902d48d82803ede6aad8"
- integrity sha512-d51brTeqC+BHlwF0BhPtcYgF5nlzf9ZZ0ZIUQNZpc9ZB9qw5IJ2diTrBY9jlCJkTLITYPjmiX6OWCwH+fuyNgQ==
- dependencies:
- stackframe "^1.1.1"
-
-error-stack-parser@^2.1.4:
+error-stack-parser@^2.0.6, error-stack-parser@^2.1.4:
version "2.1.4"
resolved "https://registry.yarnpkg.com/error-stack-parser/-/error-stack-parser-2.1.4.tgz#229cb01cdbfa84440bfa91876285b94680188286"
integrity sha512-Sk5V6wVazPhq5MhpO+AUxJn5x7XSXGl1R93Vn7i+zS15KDVxQijejNCrz8340/2bgLBjR9GtEG8ZVKONDjcqGQ==
@@ -13486,14 +13479,7 @@ serialize-javascript@^4.0.0:
dependencies:
randombytes "^2.1.0"
-serialize-javascript@^6.0.0:
- version "6.0.0"
- resolved "https://registry.yarnpkg.com/serialize-javascript/-/serialize-javascript-6.0.0.tgz#efae5d88f45d7924141da8b5c3a7a7e663fefeb8"
- integrity sha512-Qr3TosvguFt8ePWqsvRfrKyQXIiW+nGbYpy8XK24NQHE83caxWt+mIymTT19DGFbNWNLfEwsrkSmN64lVWB9ag==
- dependencies:
- randombytes "^2.1.0"
-
-serialize-javascript@^6.0.2:
+serialize-javascript@^6.0.0, serialize-javascript@^6.0.2:
version "6.0.2"
resolved "https://registry.yarnpkg.com/serialize-javascript/-/serialize-javascript-6.0.2.tgz#defa1e055c83bf6d59ea805d8da862254eb6a6c2"
integrity sha512-Saa1xPByTTq2gdeFZYLLo+RFE35NHZkAbqZeWNd3BpzppeVisAqpDjcp8dyf6uIvEqJRd46jemmyA4iFIeVk8g==
@@ -13766,7 +13752,7 @@ source-map@0.6.1, source-map@^0.6.0, source-map@^0.6.1, source-map@~0.6.0, sourc
resolved "https://registry.yarnpkg.com/source-map/-/source-map-0.6.1.tgz#74722af32e9614e9c287a8d0bbde48b5e2f1a263"
integrity sha512-UjgapumWlbMhkBgzT7Ykc5YXUT46F0iKu8SGXq0bcwP5dz/h0Plj6enJqjz1Zbq2l5WaqYnrVbwWOWMyF3F47g==
-source-map@0.7.3, source-map@^0.7.3:
+source-map@0.7.3:
version "0.7.3"
resolved "https://registry.yarnpkg.com/source-map/-/source-map-0.7.3.tgz#5302f8169031735226544092e64981f751750383"
integrity sha512-CkCj6giN3S+n9qrYiBTX5gystlENnRW5jZeNLHpe6aue+SrHcG5VYwujhW9s4dY31mEGsxBDrHR6oI69fTXsaQ==
@@ -13776,7 +13762,7 @@ source-map@^0.5.6:
resolved "https://registry.yarnpkg.com/source-map/-/source-map-0.5.7.tgz#8a039d2d1021d22d1ea14c80d8ea468ba2ef3fcc"
integrity sha1-igOdLRAh0i0eoUyA2OpGi6LvP8w=
-source-map@^0.7.4:
+source-map@^0.7.3, source-map@^0.7.4:
version "0.7.4"
resolved "https://registry.yarnpkg.com/source-map/-/source-map-0.7.4.tgz#a9bbe705c9d8846f4e08ff6765acf0f1b0898656"
integrity sha512-l3BikUxvPOcn5E74dZiq5BGsTb5yEwhaTSzccU6t4sDOH8NWJCstKO5QT2CvtFoK6F0saL7p9xHAqHOlCPJygA==
@@ -13902,12 +13888,7 @@ stack-utils@^2.0.3:
dependencies:
escape-string-regexp "^2.0.0"
-stackframe@^1.1.1:
- version "1.2.0"
- resolved "https://registry.yarnpkg.com/stackframe/-/stackframe-1.2.0.tgz#52429492d63c62eb989804c11552e3d22e779303"
- integrity sha512-GrdeshiRmS1YLMYgzF16olf2jJ/IzxXY9lhKOskuVziubpTYcYqyOwYeJKzQkwy7uN0fYSsbsC4RQaXf9LCrYA==
-
-stackframe@^1.3.4:
+stackframe@^1.1.1, stackframe@^1.3.4:
version "1.3.4"
resolved "https://registry.yarnpkg.com/stackframe/-/stackframe-1.3.4.tgz#b881a004c8c149a5e8efef37d51b16e412943310"
integrity sha512-oeVtt7eWQS+Na6F//S4kJ2K2VbRlS9D43mAlMyVpVWovy9o+jfgH8O9agzANzaiLjclA0oYzUXEM4PurhSUChw==