From 4178b36c45862628a7a796a79716a5a0e3e11b08 Mon Sep 17 00:00:00 2001 From: Kai Vandivier Date: Fri, 1 Nov 2024 17:57:02 +0100 Subject: [PATCH] docs: small revisions in react 18 section --- docs/migration/v12.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/migration/v12.md b/docs/migration/v12.md index 96668d6e..3e4a039b 100644 --- a/docs/migration/v12.md +++ b/docs/migration/v12.md @@ -79,7 +79,7 @@ Check out the [script docs](../scripts/migrate/js-to-jsx.md) for options, tips, ## React 18 -With this update we also upgraded from React 16 to React 18. Upgrading to `@dhis2/cli-app-scripts` version 12 should generally a smooth process for the consuming apps. Most of the [changes](https://react.dev/blog/2022/03/08/react-18-upgrade-guide) shouldn't affect most apps. +With this update, we also upgraded from React 16 to React 18. Upgrading to `@dhis2/cli-app-scripts` version 12 should generally a smooth process for the consuming apps. Most of the [changes](https://react.dev/blog/2022/03/08/react-18-upgrade-guide) shouldn't affect most apps. ### Default props @@ -289,7 +289,7 @@ describe('', () => { Enzyme is [considered dead](https://dev.to/wojtekmaj/enzyme-is-dead-now-what-ekl): there is no official adapter for React 18 (or 17), so it's best to [migrate to React Testing Library](https://testing-library.com/docs/react-testing-library/migrate-from-enzyme/) for tests, if possible. :::tip -If it's not currently possible to migrate, there is an [unofficial React 18 adapter](https://github.com/cfaester/enzyme-adapter-react-18) that can help in the mean time. However, it is highly recommended this is a temporary solution and you should still schedule migrating away from Enzyme. +If it's not currently possible to migrate, there is an [unofficial React 18 adapter](https://github.com/cfaester/enzyme-adapter-react-18) that can help in the mean time. However, this should be considered a temporary solution, and migrating away from Enzyme should be scheduled. ::: ## Environment variables