From cd99b541fc6bdb0ef1d06fccb5a2a0c47e45a2ac Mon Sep 17 00:00:00 2001
From: Edoardo Sabadelli <edoardo@dhis2.org>
Date: Fri, 9 Aug 2024 10:03:29 +0200
Subject: [PATCH] fix: remove eslint disable and fix useEffect dep list

---
 .../DashboardPluginWrapper/DashboardPluginWrapper.js        | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/src/components/DashboardPluginWrapper/DashboardPluginWrapper.js b/src/components/DashboardPluginWrapper/DashboardPluginWrapper.js
index 74c611161..e21986a5e 100644
--- a/src/components/DashboardPluginWrapper/DashboardPluginWrapper.js
+++ b/src/components/DashboardPluginWrapper/DashboardPluginWrapper.js
@@ -29,11 +29,7 @@ const CacheableSectionWrapper = ({ id, children, isParentCached }) => {
             // -- a back-up to imperative `removeCachedData`
             remove()
         }
-
-        // NB: Adding `startRecording` to dependencies causes
-        // an infinite recording loop as-is (probably need to memoize it)
-        // eslint-disable-next-line react-hooks/exhaustive-deps
-    }, [isParentCached])
+    }, [isCached, isParentCached, remove, startRecording])
 
     return (
         <CacheableSection id={id} loadingMask={<LoadingMask />}>