From 1edfdac8bf56e39bc0f34fbcc231b9a2cc5274f8 Mon Sep 17 00:00:00 2001
From: Jen Jones Arnesen <jennifer@dhis2.org>
Date: Tue, 23 Apr 2019 21:13:29 +0200
Subject: [PATCH] fix: adjustments to heights and positions in ItemSelector
 (#17)

Fixes include:

* reduce height of ItemSelector by 24px so that the total height of the dialog stays under 768px which is our minimum supported resolution.
* adjust position of the "Select" button by a few pixels
* a few other small pixel adjustments to attempt to ensure that odd browsers are less likely to show a scrollbar.
---
 src/components/ItemSelector/styles/ItemSelector.style.js    | 6 +++---
 src/components/ItemSelector/styles/SelectedItems.style.js   | 1 -
 src/components/ItemSelector/styles/UnselectedItems.style.js | 2 +-
 3 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/src/components/ItemSelector/styles/ItemSelector.style.js b/src/components/ItemSelector/styles/ItemSelector.style.js
index 98cb37028..e7f9d23bd 100644
--- a/src/components/ItemSelector/styles/ItemSelector.style.js
+++ b/src/components/ItemSelector/styles/ItemSelector.style.js
@@ -13,16 +13,16 @@ export default css`
         border: 1px solid ${colors.greyLight};
         display: flex;
         flex-direction: column;
-        height: 534px;
+        height: 510px;
         position: relative;
     }
 
     .unselected {
         margin-right: 55px;
-        width: 419px;
+        width: 418px;
     }
 
     .selected {
-        width: 277px;
+        width: 276px;
     }
 `
diff --git a/src/components/ItemSelector/styles/SelectedItems.style.js b/src/components/ItemSelector/styles/SelectedItems.style.js
index 2776cb72a..a5f02f85a 100644
--- a/src/components/ItemSelector/styles/SelectedItems.style.js
+++ b/src/components/ItemSelector/styles/SelectedItems.style.js
@@ -4,7 +4,6 @@ import css from 'styled-jsx/css'
 export default css`
     .selected-list {
         flex: 1;
-        height: 455px;
         list-style: none;
         margin: 0px;
         overflow-y: auto;
diff --git a/src/components/ItemSelector/styles/UnselectedItems.style.js b/src/components/ItemSelector/styles/UnselectedItems.style.js
index 732944533..0b4594be7 100644
--- a/src/components/ItemSelector/styles/UnselectedItems.style.js
+++ b/src/components/ItemSelector/styles/UnselectedItems.style.js
@@ -26,7 +26,7 @@ export default css`
     }
 
     .select-highlighted-button {
-        left: 429px;
+        left: 426px;
         position: absolute;
         top: 230px;
     }