Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dhall-1.42.0 fails to build in Stackage Nightly #2516

Closed
juhp opened this issue Apr 20, 2023 · 7 comments
Closed

dhall-1.42.0 fails to build in Stackage Nightly #2516

juhp opened this issue Apr 20, 2023 · 7 comments

Comments

@juhp
Copy link

juhp commented Apr 20, 2023

       Building library for dhall-1.42.0..
       [69 of 77] Compiling Dhall.TH
       
       /var/stackage/work/unpack-dir/unpacked/dhall-1.42.0-d29671176e59c6861b5d2ff055de0a8160793e10de281c46a8279821c9efc88d/src/Dhall/TH.hs:274:38: error:
           • Couldn't match type: flag0 -> Syntax.TyVarBndr flag0
                            with: Syntax.TyVarBndr ()
             Expected: [Syntax.TyVarBndr ()]
               Actual: [flag0 -> Syntax.TyVarBndr flag0]
           • In the third argument of ‘DataD’, namely ‘params’
             In the expression:
               DataD [] name params Nothing constructors derivingClauses
             In the first argument of ‘pure’, namely
               ‘[DataD [] name params Nothing constructors derivingClauses]’
           |
       274 |                 [pure [DataD [] name params Nothing constructors derivingClauses]] <>
           |                                      ^^^^^^
juhp added a commit to commercialhaskell/stackage that referenced this issue Apr 20, 2023
@sjakobi
Copy link
Collaborator

sjakobi commented Apr 20, 2023

I can reproduce this with GHC 9.0.1, 9.0.2, 9.2.4 and 9.4.4, and have made a corresponding revision on Hackage: https://hackage.haskell.org/package/dhall-1.42.0/revisions/

The issue was apparently introduced in #2506 or an earlier change to that file (CC @ndwarshuis).

I don't understand why CI didn't catch this issue though – I thought the ubuntu-latest and windows-latest jobs are using GHC 9.0.1.

@sjakobi
Copy link
Collaborator

sjakobi commented Apr 21, 2023

I don't understand why CI didn't catch this issue though – I thought the ubuntu-latest and windows-latest jobs are using GHC 9.0.1.

These jobs don't make use of the installed "Haskell environment" though – they use stack with lts-18.18 which is based on GHC-8.10.7.

I guess it's high time to add CI with a recent version of GHC.

@alaendle
Copy link

@sjakobi - to enable dhall-1.42.0 in nightly we also need relaxed bounds for template-haskell and unix-compat.

template-haskell-2.19.0.0 (changelog) is out of bounds for:

unix-compat-0.7 (changelog) (Mitchell Rosen [email protected] @mitchellwrosen) is out of bounds for:

@ocharles
Copy link
Member

I think it's more than relaxing bounds for unix-compat - dhall-1.42 doesn't build with unix-compat-0.7.

@chenrui333
Copy link

any update on this thread?

@ysangkok
Copy link
Contributor

ysangkok commented Oct 27, 2023 via email

@Gabriella439
Copy link
Collaborator

Yeah, I'm closing this as I'm fairly confident this is fixed in master and will be fixed in the next release of dhall. (I've been meaning to release it soon, but have just been very busy, but I hope to get to cutting the release this Sunday)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants