Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Windows tests are never finishing #2237

Closed
MarcosJLR opened this issue Jun 30, 2021 · 5 comments
Closed

Some Windows tests are never finishing #2237

MarcosJLR opened this issue Jun 30, 2021 · 5 comments
Labels
build Building, testing, installing, packaging, etc

Comments

@MarcosJLR
Copy link
Collaborator

I have noticed that since PR #2196 was merged into master, the AppVeyor build and the github action main / dhall on windows-latest (push) are both being cancelled for taking too long (60 min on AppVeyor and 360 min on GitHub).

I don't know why it is happening and I think is worth that someone with more experience reviews it 😅

@Gabriella439
Copy link
Collaborator

So I just disabled the Appveyor build in factor of the GitHub build, but I'll still need to debug the GitHub build

@sjakobi
Copy link
Collaborator

sjakobi commented Jul 6, 2021

For reference, here's one of the failed Windows jobs: https://github.com/dhall-lang/dhall-haskell/runs/2979018865

@sjakobi
Copy link
Collaborator

sjakobi commented Jul 7, 2021

For comparison, here's the successful CI job from the parent of the problematic c23e4d5: https://github.com/dhall-lang/dhall-haskell/runs/2917448856

(CC @mmhat)

sjakobi added a commit that referenced this issue Jul 7, 2021
@sjakobi
Copy link
Collaborator

sjakobi commented Jul 7, 2021

Since it seems that the dhall:doctest suite passes all the tests but then fails to finish, I've reported the issue at sol/doctest#300.

@sjakobi sjakobi added build Building, testing, installing, packaging, etc and removed discuss labels Jul 10, 2021
sjakobi added a commit that referenced this issue Jul 30, 2021
…but keep the problematic doctests disabled.

This reverts commit 06dac3d.

Context: #2237
@sjakobi
Copy link
Collaborator

sjakobi commented Oct 22, 2021

So the status quo on this issue is that the dhall:doctest test suite is disabled on Windows:

Test-Suite doctest
Type: exitcode-stdio-1.0
Hs-Source-Dirs: doctest
Main-Is: Main.hs
GHC-Options: -Wall
Build-Depends:
base ,
directory ,
filepath < 1.5 ,
mockery < 0.4 ,
doctest >= 0.7.0 && < 0.19
if os(windows)
-- https://github.com/dhall-lang/dhall-haskell/issues/2237
Buildable: False
Default-Language: Haskell2010

AFAIK this test suite isn't very important for checking cross-platform correctness, so it's not a big problem. When sol/doctest#300 is fixed or once we're using a more recent GHC version in the Windows builds, we can try re-enabling the test suite.

@sjakobi sjakobi closed this as completed Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Building, testing, installing, packaging, etc
Projects
None yet
Development

No branches or pull requests

3 participants