-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise visibility of this package? #103
Comments
On reflection, I think you should rename. I've noticed a couple of times I wanted to call functions in this package with |
Thanks for giving it some thought. I wouldn't want to give an impression that only fringes are supported, so the My only misgiving about Speaking of a rename, any advice? If I rename the package and the repository at once, will the last version of |
Yeah, I don't think that's really a problem, personally.
The last To do things more gradually, rename the repo via github, have both |
Which just means that it got a lot of attention sometime(s) along the way. Nothing a few blog posts about The situation looks a little better when consulting Melpa statistics.
What really annoys me is the success of After trying to get this sorted out in 2014 (nonsequitur/git-gutter-plus#11) I went with I recommend against renaming. That's just going to be confusing and you don't actually know that more users will find this package after doing so. If you rename to |
Yep, |
Prelude, I think, but not Spacemacs (which still uses |
I wonder, does it even have any features these days that the parent doesn't?
They probably would, eventually. Looking around, the term "gutter" is pretty established these days across editors.
Because "version control" is a general term, too? Not to mention that it uses VC. Not every Magit user is going to be aware of the built-in VC package anyway, and the most clever ones of those that do also set Anyway, how about |
I like that. |
|
I'm up for renaming as well. This is a superior package with this kind of functionality for emacs, but its name is just undiscoverable. |
Hi, Quick reply to all previous posts: Shouldn't the short description provide the necessary discoverability? I don't think a rename would be beneficial, and that an updated short description would provide the necessary search keys. I'm investigating packaging something that highlights changed lines for Debian, and the investigation was prompted by an RFP (request for packaging) for git-gutter-fringe (Bug #920383). Here's an updated table:
Magit included as a control. When choosing between alternatives to package for Debian I take the delta between the stable and unstable percentile into account, but so far it's a toss up between git-gutter and diff-hl, with diff-hl edging ahead because it's a living project. @tarsius @dgutov interestingly, Four things that I believe would increase its discoverability/usage are:
Beyond that, a lot of people seem to want line numbers plus highlighting of changed lines. Personally I think it'd be cool if individual line numbers could be fontified/colourised for use with Emacs ≥26 Cheers, |
@sten0 I'm thankful for any suggestions how to improve the summary and the description, but I haven't used Magit for a few years now personally, so for any features I would prefer implementations that don't rely on it. But if Magit-based commands are self-contained, people are welcome to propose some. I'm totally fine with adding a link to Magit's website in the README if it helps. Note that the integration described in the relevant section is not automatic (people still have to add it to their init scripts). I could make it automatic, but we still have a seemingly-unresolved issue related to it (#65). |
@sten0 You haven't explained why you think a rename would be wrong, though. Losing search engine ranking? Github would create a redirect. Regarding the coloring of line numbers, I'm not really sure it's possible (the new feature is implemented on the C level, and it's not very customizable). You're welcome to file a separate feature request in Emacs or here (I will pass it on then). |
Hi @dgutov,
Thank you for maintaining diff-hl, and thank you for the quick reply!
On Thu, May 09, 2019 at 06:45:28AM -0700, Dmitry Gutov wrote:
@sten0 I'm thankful for any suggestions how to improve the summary and the description, but `diff-hl` is not a plug-in for Magit, so it cannot be advertised as such (it works when Magit is not installed, and it will fail to work if the user disables the built-in VC subsystem, even when Magit would continue to work).
Ok, I'll see what I can come up with :-) Of course, someone who works
in search engine optimisation will have more useful insights. Please
ping me if I seem to be taking too long.
I haven't used Magit for a few years now personally, so for any features I would prefer implementations that don't rely on it. But if Magit-based commands are self-contained, people are welcome to propose some.
I'm totally fine with adding a link to Magit's website in the README if it helps. Note that the integration described in the relevant section is not automatic (people still have to add it to their init scripts). I could make it automatic, but we still have a seemingly-unresolved issue related to it (#65).
I was thinking of something along the lines of some kind of opt-in
defcustom that activates magit integration(and potential workarounds)
and disables VC when a git repo is detected. If this was enabled but
magit is not installed diff-hl would error when loading and fall back
to VC. Alternatively I could just file a wishlist bug against magit,
but that wouldn't help increase the userbase for diff-hl ;-) Of
course I'm still willing to package diff-hl for Debian, even though I
feel that VC and not Magit limits it to more niche appeal (I know one
or two people who use VC and more than a dozen who use Magit).
@stribb, from #65
I tracked it down as far as (normal-mode) which runs
after-change-major-mode-hook. The two hook functions which cause the
infinite loop are magit-auto-revert-mode-enable-in-buffers and
diff-hl-mode-enable-in-buffers.
Do you think a magit code path for diff-hl would be a good way to work
around this? Eg: that diff-hl would take a different branch when
using VC vs when using magit.
Sincerely,
Nicholas
|
That's doesn't sound right. Magit integration works without disabling VC. Basically: Magit tells us when to update a buffer, but we still use VC to get the diff.
I'm pretty sure there are a lot more of us. VC is installed by default, you don't need to configure anything to use it. So a lot of people use at least one or two features of it.
Whatever happens, already happens in a Magit code path. We could do something differently, but we'll need Magit people to tell us what. If the bug is still valid, of course. |
Hi Dmitry,
Sorry for the delay, my mailbox and workload blew up and I'm only
catching up now.
On Thu, May 09, 2019 at 06:49:18AM -0700, Dmitry Gutov wrote:
***@***.*** You haven't explained why you think a rename would be wrong,
though. Losing search engine ranking? Github would create a redirect.
I don't think it's wrong so much as probably counterproductive to the
stated objective... In addition to the reasons @tarsius presented
over a year ago, here are a couple more:
At least 2/3 of the Emacs users I know are change averse, and an
incidence where change is required becomes an opportunity to see what
else is out there, reevaluate, and switch to something else; a rename
that requires config changes risks losing users. Also, I think the
6months rename transition is counterproductive if the primary aim is
to increase userbase, unless one has an aggressive rebranding campaign
(at a minimum lots of people writing lots of articles)...and even then
it doesn't work well. eg: Plasma Desktop. On the Emacs side, people
are still confused about Counsel -> Ivy, and most new users ignore
Counsel and only install Ivy.
Here is the Debian-side of things: I could add a "new-name PROVIDES
diff-hl" as long as new-name will work with config files written for
old-name, as long as a `s/diff-hl/new-name/` for these config files
isn't required, and it would be totally transparent to the user (eg:
`apt install elpa-diff-el` would automatically map to
`elpa-new-name`). Otherwise the diff-hl package just disappears in
the next Debian version and users won't know about `new-name`. If
compatibility is maintained for four or five years there probably
wouldn't be an issue.
But for maximal user adoption, have you considered upstreaming diff-hl
to Emacs proper? Then all users have it. As Magit is 3rd party it
can just be ignored then, and there should be better opportunities for
deeper integration (eg: the `line-number-mode` thing, focusing on VC,
etc.)
Cheers,
Nicholas
|
P.S. oh, and since upstreaming is an opportunity for a major epoch break you can rename it to whatever you want without maintaining backwards compatibility. Clean slate :-) |
P.P.S.
If diff-hl is upstreamed I'm sure the Magit people would modify Magit to provide the hint diff-hl. Bam, ~731,573 users ;-) |
Hi again, Nicholas!
I see your point here, but I'm not really worried about a scenario like this. If somebody knows about this package, has tried it for a while, and then goes on to use something else, that's just fine with me. It's not the kind of package that's likely to invite lots of contributions anyway, and I'm not after high scores in download counts, or etc. A change being discussed here would be done solely for visibility among the people who hadn't heard about it yet. Further, Plasma Desktop, which you compared against, is in a more difficult position where the competition is a lot more viable and well-maintained. Speaking of upstreaming, though... that's a new idea. Nobody on the core asked for it. Not sure what the benefit would be for an average user, considering this package is already in GNU ELPA, and as such, installable right away. |
I know this is old, but I am all in for |
We have
emacs-git-gutter
for comparison, which is a younger project, and yet about twice as popular (according to GitHub's star count).If there are easy ways to improve the situation (e.g. a rename, @purcell suggested "vc-gutter", but advised against this move in general). Or improving the README, to change the first impression. Then let's do it.
If the reasons are more difficult (e.g. strong Japanese following), then maybe not.
The text was updated successfully, but these errors were encountered: