From e028a76429bd6a62efdc1057a060bb471c7aa1bc Mon Sep 17 00:00:00 2001
From: "David G. Moore, Jr." <david@dgmjr.io>
Date: Thu, 21 Dec 2023 23:16:59 -0500
Subject: [PATCH] Updated build targets and silenced warning RCS1139
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Upgraded the `.nuproj` to ensure SDK project is packable, ensuring compatibility with modern build environments. Additionally, streamlined license file handling by incorporating `PackageLicenseFile` in `EnsureLicense.targets`. Improved maintainability by consolidating `TargetFramework` into `Directory.Build.props` to apply across all projects. Also added a new warning, RCS1139, to the `NoWarn` list to suppress related noise during build.

Resolves #42 – "Ensure SDK is packable"
Closes #55 – "Suppress additional warnings for cleaner builds"
---
 src/Build/EnsureLicense.targets |  3 ++
 src/Build/NoWarn.targets        |  2 +-
 src/DgmjrSdk.nuproj             |  2 +-
 src/Directory.Build.props       | 75 +++++++++++++++++----------------
 4 files changed, 44 insertions(+), 38 deletions(-)

diff --git a/src/Build/EnsureLicense.targets b/src/Build/EnsureLicense.targets
index f503660..1bbe0a7 100644
--- a/src/Build/EnsureLicense.targets
+++ b/src/Build/EnsureLicense.targets
@@ -14,5 +14,8 @@
   <Target Name="EnsureLicenseFileExists" BeforeTargets="Pack" Condition="!$(LicenseFileExists)">
     <Copy SourceFiles="$(MSBuildThisFileDirectory)../LICENSE.md"
           DestinationFolder="$(MSBuildProjectDirectory)" />
+    <PropertyGroup>
+      <PackageLicenseFile>LICENSE.md</PackageLicenseFile>
+    </PropertyGroup>
   </Target>
 </Project>
diff --git a/src/Build/NoWarn.targets b/src/Build/NoWarn.targets
index 7fea0f5..b2ec051 100755
--- a/src/Build/NoWarn.targets
+++ b/src/Build/NoWarn.targets
@@ -2,7 +2,7 @@
   <PropertyGroup>
     <DisableMostAnnoyingWarnings>true</DisableMostAnnoyingWarnings>
     <RestoreDependsOn>$(RestoreDependsOn);NoWarn</RestoreDependsOn>
-    <NoWarn>$(NoWarn);CA2252;CS8335;NU1603;CS8981;NU1605;S3604;</NoWarn>
+    <NoWarn>$(NoWarn);CA2252;CS8335;NU1603;CS8981;NU1605;S3604;RCS1139;</NoWarn>
   </PropertyGroup>
   <ItemDefinitionGroup>
     <NoWarn>
diff --git a/src/DgmjrSdk.nuproj b/src/DgmjrSdk.nuproj
index 3515021..b968e29 100644
--- a/src/DgmjrSdk.nuproj
+++ b/src/DgmjrSdk.nuproj
@@ -14,9 +14,9 @@
   <PropertyGroup>
     <ProjectGuid>EB008C4C-9C3A-4498-A19D-34A42B6E2CE1</ProjectGuid>
     <ProjectTypeGuid>FAE04EC0-301F-11D3-BF4B-00C04F79EFBC</ProjectTypeGuid>
-    <TargetFramework>netstandard1.0</TargetFramework>
     <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
     <IsNuGetized>true</IsNuGetized>
+    <IsPackable>true</IsPackable>
   </PropertyGroup>
   <PropertyGroup>
     <Title>The DGMJR-IO SDK</Title>
diff --git a/src/Directory.Build.props b/src/Directory.Build.props
index 87d4df1..e096eba 100644
--- a/src/Directory.Build.props
+++ b/src/Directory.Build.props
@@ -11,40 +11,43 @@
 -->
 
 <Project>
-    <!-- <Import Project="./Build/TargetFraneworks.props" /> -->
-    <Import Project="./Build/AIsMultiTargeting.props" />
-    <Import Project="./Build/AAGitRoot.props" />
-    <Import Project="./Build/ADefaultBuildConfiguration.props" />
-    <Import Project="./Build/AssemblySigning.props" />
-    <Import Project="./Build/Authors-Owners.props" />
-    <Import Project="./Build/BuildConfigurations.props" />
-    <Import Project="./Build/BuildFromSource.props" />
-    <Import Project="./Build/CentralPackages.props" />
-    <Import Project="./Build/CentralPackagesFile.props" />
-    <Import Project="./Build/CentralPackageVersions.props" />
-    <Import Project="./Build/CompilerVisibleProperties.props" />
-    <Import Project="./Build/CopyLocalLockFileAssemblies.props" />
-    <Import Project="./Build/CustomBeforeAndAfterNoTargets.props" />
-    <Import Project="./Build/Deterministic.props" />
-    <Import Project="./Build/EnsureLicense.props" />
-    <Import Project="./Build/EmbeddedResourcesStringExtensions.props" />
-    <Import Project="./Build/EmitNuspec.props" />
-    <Import Project="./Build/EnablePreviewFeatures.props" />
-    <Import Project="./Build/MinVer.props" />
-    <Import Project="./Build/NuGetizer.props" />
-    <Import Project="./Build/NuGetOutputs.props" />
-    <Import Project="./Build/PackageIcon.props" />
-    <Import Project="./Build/PackageMetadata.props" />
-    <Import Project="./Build/PackageProjectUrl.props" />
-    <Import Project="./Build/PackageReadme.props" />
-    <Import Project="./Build/PackageTags.props" />
-    <Import Project="./Build/PackageVersionOverride.props" />
-    <Import Project="./Build/ProjectMetadata.props" />
-    <Import Project="./Build/ProjectTypeInfo.props" />
-    <Import Project="./Build/SlnGen.props" />
-    <Import Project="./Build/SourceLinkPatch.props" />
-    <Import Project="./Build/TargetFrameworks.props" />
-    <Import Project="./Build/Testing.props" />
-    <Import Project="./Build/TestingLocal.props" />
-    <Import Project="./Build/UserSecrets.props" />
+  <PropertyGroup>
+    <TargetFramework>netstandard1.0</TargetFramework>
+  </PropertyGroup>
+  <!-- <Import Project="./Build/TargetFraneworks.props" /> -->
+  <Import Project="./Build/AIsMultiTargeting.props" />
+  <Import Project="./Build/AAGitRoot.props" />
+  <Import Project="./Build/ADefaultBuildConfiguration.props" />
+  <Import Project="./Build/AssemblySigning.props" />
+  <Import Project="./Build/Authors-Owners.props" />
+  <Import Project="./Build/BuildConfigurations.props" />
+  <Import Project="./Build/BuildFromSource.props" />
+  <Import Project="./Build/CentralPackages.props" />
+  <Import Project="./Build/CentralPackagesFile.props" />
+  <Import Project="./Build/CentralPackageVersions.props" />
+  <Import Project="./Build/CompilerVisibleProperties.props" />
+  <Import Project="./Build/CopyLocalLockFileAssemblies.props" />
+  <Import Project="./Build/CustomBeforeAndAfterNoTargets.props" />
+  <Import Project="./Build/Deterministic.props" />
+  <Import Project="./Build/EnsureLicense.props" />
+  <Import Project="./Build/EmbeddedResourcesStringExtensions.props" />
+  <Import Project="./Build/EmitNuspec.props" />
+  <Import Project="./Build/EnablePreviewFeatures.props" />
+  <Import Project="./Build/MinVer.props" />
+  <Import Project="./Build/NuGetizer.props" />
+  <Import Project="./Build/NuGetOutputs.props" />
+  <Import Project="./Build/PackageIcon.props" />
+  <Import Project="./Build/PackageMetadata.props" />
+  <Import Project="./Build/PackageProjectUrl.props" />
+  <Import Project="./Build/PackageReadme.props" />
+  <Import Project="./Build/PackageTags.props" />
+  <Import Project="./Build/PackageVersionOverride.props" />
+  <Import Project="./Build/ProjectMetadata.props" />
+  <Import Project="./Build/ProjectTypeInfo.props" />
+  <Import Project="./Build/SlnGen.props" />
+  <Import Project="./Build/SourceLinkPatch.props" />
+  <Import Project="./Build/TargetFrameworks.props" />
+  <Import Project="./Build/Testing.props" />
+  <Import Project="./Build/TestingLocal.props" />
+  <Import Project="./Build/UserSecrets.props" />
 </Project>