Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

true, false are displayed as "true", "false" instead of TRUE, FALSE #18

Closed
armenic opened this issue Aug 6, 2023 · 2 comments
Closed

Comments

@armenic
Copy link
Contributor

armenic commented Aug 6, 2023

I tried my best to locate the bug, but could not :(.

To reproduce:

$ cargo run
> true
[1] true
> false
[1] false
> c(true, false)
[1]  true false
> c(true, false, "a")
[1]  "true" "false"     "a"
> TRUE
[1] true
> FALSE
[1] false
> c(TRUE, FALSE, "a")
[1]  "true" "false"     "a"
> 
@dgkf
Copy link
Owner

dgkf commented Aug 7, 2023

Yes, you're right! It's an intentional deviation (described in #6) from R. TRUE/FALSE and true/false all map to the same boolean representations.

TRUE/FALSE/NULL is still provided as legacy for the folks that are trying to speedrun carpal tunnel.

No worries though, there's no clear spec that I'm following - just taking liberties where they feel appropriate. If the project grows into anything more substantial I'll take the time to jot down some guiding principles.

@dgkf dgkf closed this as completed Aug 7, 2023
@armenic
Copy link
Contributor Author

armenic commented Aug 7, 2023

Yes, you're right! It's an intentional deviation (described in #6) from R. TRUE/FALSE and true/false all map to the same boolean representations.

TRUE/FALSE/NULL is still provided as legacy for the folks that are trying to speedrun carpal tunnel.

No worries though, there's no clear spec that I'm following - just taking liberties where they feel appropriate. If the project grows into anything more substantial I'll take the time to jot down some guiding principles.

Thanks Doug, it would be great to have guiding principles and a high level architecture diagram or slide. I still mostly feel uncomfortable with the crate, though it feels much familiar now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants