Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data and validation #60

Open
burlen opened this issue Sep 30, 2022 · 1 comment
Open

data and validation #60

burlen opened this issue Sep 30, 2022 · 1 comment

Comments

@burlen
Copy link

burlen commented Sep 30, 2022

I'm using the sample_data.nc file you provide with the source code for validation but there are some small issues.

The time coordinates (month variable) are not specified in a standard way. For instance this variable does not have a calendar, and the units (Month Number) are not recognized by udunits.

Would it be possible to

  1. change the units of the month variable to something more conventional such as "months since 1980-01-01"?
  2. add a calendar attribute such as "standard" to the month variable?

In the run_sample.py you're passing q from the sample_data.nc file without conversion (here). The netcdf attributes in the file suggest that q is specific humidity while the tcpyPI documentation on states that a mixing ratio is required. Should there be a conversion applied?

@burlen
Copy link
Author

burlen commented Sep 30, 2022

for context our code parallelizes calculations over space and time such that a large climate dataset can be processed concurrently using high performance computing hardware. Various pieces of the system depend on standardized time dimension. We're using tcpyPI and would like to validate directly on the data you provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant