You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If knowledge interface is not initialized before calling Action, the code fails when trying to apply postconditions but not when checking parameters.
After checking the source code I realized that validate_parameters method of CheckActionAndProcessEffects create the services that connect to KB ROSPlan by itself while apply_effects is using the knowledge interface of rosplan_pytools. And this explain why checking parameters works without initializing knowledge interface.
This seems wrong as same approach to connect to ROSPlan KB should be used by CheckActionAndProcessEffects. Therefore, it should be analyzed why the used approach is different and fix if same approach could be used.
dgerod
changed the title
_CheckActionAndProcessEffects_ uses two different approaches to call ROSPlan KB and they should be unified
'CheckActionAndProcessEffects' uses two different ways to call KB of ROSPlan, they should be unified
Sep 26, 2020
If knowledge interface is not initialized before calling Action, the code fails when trying to apply postconditions but not when checking parameters.
After checking the source code I realized that validate_parameters method of CheckActionAndProcessEffects create the services that connect to KB ROSPlan by itself while apply_effects is using the knowledge interface of rosplan_pytools. And this explain why checking parameters works without initializing knowledge interface.
This seems wrong as same approach to connect to ROSPlan KB should be used by CheckActionAndProcessEffects. Therefore, it should be analyzed why the used approach is different and fix if same approach could be used.
More information: #17
The text was updated successfully, but these errors were encountered: