Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'CheckActionAndProcessEffects' uses two different ways to call KB of ROSPlan, they should be unified #18

Open
dgerod opened this issue Sep 26, 2020 · 0 comments

Comments

@dgerod
Copy link
Owner

dgerod commented Sep 26, 2020

If knowledge interface is not initialized before calling Action, the code fails when trying to apply postconditions but not when checking parameters.

After checking the source code I realized that validate_parameters method of CheckActionAndProcessEffects create the services that connect to KB ROSPlan by itself while apply_effects is using the knowledge interface of rosplan_pytools. And this explain why checking parameters works without initializing knowledge interface.

This seems wrong as same approach to connect to ROSPlan KB should be used by CheckActionAndProcessEffects. Therefore, it should be analyzed why the used approach is different and fix if same approach could be used.

More information: #17

@dgerod dgerod changed the title _CheckActionAndProcessEffects_ uses two different approaches to call ROSPlan KB and they should be unified 'CheckActionAndProcessEffects' uses two different ways to call KB of ROSPlan, they should be unified Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant