Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spread operator from umd bundle #23

Open
dawsbot opened this issue Apr 13, 2020 · 1 comment
Open

Remove spread operator from umd bundle #23

dawsbot opened this issue Apr 13, 2020 · 1 comment

Comments

@dawsbot
Copy link

dawsbot commented Apr 13, 2020

We're getting prod errors in the Everipedia.org site for browsers which do not support the spread operator (...).

After running this repo locally, it appears that dfuse-client.umd.js contains this syntax, which should not land in user's browsers untranspiled.

None of the other dist outputs contain this, so I'm going to borrow their build syntax and PR this 🙌

@maoueh
Copy link
Contributor

maoueh commented Apr 14, 2020

The problem seems to be that https://www.npmjs.com/package/debug which is the only dependency built into the UMD build is not compatible with ES5 anymore (they now refuse to do it)

So the only option is using Babel that would transpile the debug library correctly, like you did in your PR.

I'll review the PR more thoroughly this week and take a decision. Thanks for opening and fixing the issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants